Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with micro:bit v2 #3

Closed
microbit-sam opened this issue Nov 18, 2020 · 9 comments
Closed

Compatibility with micro:bit v2 #3

microbit-sam opened this issue Nov 18, 2020 · 9 comments
Assignees

Comments

@microbit-sam
Copy link

Hi @sparkfun,

As you might have seen from microsoft/pxt-microbit#3506 this extension is currently not compiling against the latest version of Micro:bit CODAL. This means it will not work with micro:bit V2.

Software for micro:bit V2 boards is built using CODAL rather than the DAL, and no longer includes the mbed layer. We’ve implemented the most frequently used mbed classes to support easy porting of existing extensions, but there may still be corner cases with this compatibility layer.

As your extension is currently not building, it will be disabled for micro:bit V2. People attempting to use your extension with a micro:bit V2 board will get error 929. This extension will only be re-enabled on micro:bit V2 once it is fixed.

There are details on how to ensure extensions work on both version of the micro:bit here.

Looking at your extension source I believe that your extension falls under this category:

  1. Use of mbed APIs that are not included in the compatibility layer, or microbit-dal APIs that need different constructors

We're currently looking into I2C compatibility, and any updates will be tracked on

/home/build/prjclone/pxtapp/gatorEnvironment/SparkFunEnvironment.cpp:30:42: error: no matching function for call to 'codal::NRF52I2C::NRF52I2C(PinName, PinName)'
@loricrotser loricrotser self-assigned this Jan 26, 2022
@loricrotser
Copy link
Contributor

Hey @microbit-sam! I've just recently been assigned to these micro:bit issues, and after digging in a bit, I think I need some direction on the NRF52I2C support. Do you have a few minutes to reach out? I think it'll actually fix a few of the micro:bit extension issues we're seeing. Also cc'ing @finneyj. Thank you!

@MakeAndLearn
Copy link

Hi @loricrotser, how is it going? Do you think you'll be able to fix this problem?

@bsiever
Copy link
Contributor

bsiever commented Mar 12, 2022

@loricrotser. I don't have a Gator Environment to test against, but here's a version that compiles: https://github.com/bsiever/pxt-gator-environment . It needs to be tested on both V1 and V2 (changes impact both).

Here's a test project that includes it: https://makecode.microbit.org/_Mu3fTfgLCRcx

If it works ok, I'll do a PR.

(Edit/update: I cleaned the code up a tiny bit. Both repo and link were updated)

@finneyj
Copy link

finneyj commented Mar 14, 2022

Thanks for looking into these issues folks. @loricrotser please do ask away if you have any questions :)

@bsiever
Copy link
Contributor

bsiever commented Mar 22, 2022

@loricrotser PR #5 created!

@bsiever
Copy link
Contributor

bsiever commented Mar 22, 2022

@loricrotser Hopefully you can close this issue now.

@microbit-mark
Copy link

Thanks for your work on this @bsiever. @loricrotser I think you may need to run another tagged release of the extension for the updated version https://github.com/sparkfun/pxt-gator-environment/blob/master/pxt.json#L3 to be picked up in MakeCode

You can do this in https://github.com/sparkfun/pxt-gator-environment/tags

@loricrotser
Copy link
Contributor

I think I just did this? GitHub is a new animal for me... lmk

@loricrotser
Copy link
Contributor

Double checked by @bsiever. Closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants