Skip to content

Adderr #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 13, 2023
Merged

Adderr #28

merged 10 commits into from
Dec 13, 2023

Conversation

@gigapod
Copy link
Member

@gigapod gigapod commented Dec 12, 2023 •
edited
Loading

  • This merges the updates from Alex and I for the return of number of bytes from read reg region.
  • I made the stop flag a bool - since that what it is in Arduino (even though it's. weird Arduino bool :)
  • Changed getStop() to just stop() to follow the pattern being used for getters and setters (setBlah() and blah())

@SFE-Brudnerd SFE-Brudnerd merged commit 26ad778 into readregion_api_change Dec 13, 2023
@SFE-Brudnerd SFE-Brudnerd deleted the adderr branch December 14, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PaulZC PaulZC Awaiting requested review from PaulZC

1 more reviewer

@SFE-Brudnerd SFE-Brudnerd SFE-Brudnerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gigapod @SFE-Brudnerd