16 bit data support -words vs bytes - #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the I2C bus to determine if uint16_t transfers need to swap bytes; note- Arduino SPI does this correctly
…pr approach does not work on all compliers -- needs > c++11
…ade Arduino like consts for order types
…d. move to leverage the fast built in versions
-also, changing naming to reflect words not bytes -param[out] "nRead" changed to set readWords (not readBytes), this makes it more consistent with the SPI version of this function.
Member
|
Going to close this since we don't want to move everything to the main branch right now. Once everything is working and verified for all impacted devices, we and get everything ready for a PR/Merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-changing the naming of arguments to reflect words not bytes.
-@param[out] readWords on readRegister16Region16() is now being updated to the words written - to match how this is done in the SPI equivalent function.