Rename SparkRenderer.renderScale to focalAdjustment. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or options and to docs.
Contributor
|
good stuff! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added to constructor options for initialization and to docs. Included note about how it's similar to the same
focalAdjustmentparameter in MKellogg, and that a value of 2.0 matches the calculations in the PlayCanvas engine.This PR subsumes #102 by providing a parameter that people can use to adjust to their liking. This potentially fixes #99 but it will be up to the user to decide if these tweaks are enough to match their expectation.