Use FullScreenQuad instead of custom setup #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Jul 15, 2025
src/Readback.ts
Outdated
| static mesh = new THREE.Mesh( | ||
| Readback.geometry, | ||
| // Static full-screen quad for pseudo-compute shader rendering | ||
| static fsQuad = new FullScreenQuad( |
Contributor
There was a problem hiding this comment.
can we call it fullScreenQuad and avoid abbreviation ?
Contributor
There was a problem hiding this comment.
even better fullScreenTriangle to avoid three misnomer
Collaborator
Author
There was a problem hiding this comment.
Changed it to fullScreenQuad. Originally used fsQuad as that is the common name used throughout Three.js. Didn't go for fullScreenTriangle as the snippet fullScreenTriangle = new FullScreenQuad just doesn't read nicely. In a way it being a triangle is an implementation detail, and while that detail is the main motivation for this change, it isn't really needed to understand the code here.
Contributor
|
Nice, yes this will improve things a bit, thanks! |
asundqui
approved these changes
Jul 15, 2025
mrxz
force-pushed
the
fullscreen-triangle
branch
from
414180b to
69a6235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PackedSplatandReadbackclasses used a manual setup to render a quad that covers the entire render target. While this works, the quad consists of two triangles, meaning there's an edge running through the middle. While this might seem inconsequential it can have a negative impact on performance (see this post for details)This PR replaces the manual setup with the
FullScreenQuadfrom Three.js. Contrary to its name, it actually uses a fullscreen triangle under the hood.