Use material.premultipliedAlpha to adjust blending function
#136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrxz
force-pushed
the
three-normal-blending
branch
from
0632611 to
0f45622
Compare
asundqui
approved these changes
Jul 24, 2025
Contributor
asundqui
left a comment
asundqui
left a comment
There was a problem hiding this comment.
Nice! Very helpful with in-depth Three.js knowledge, the trade-off sounds good to me, unlikely the user will be changing that flag I agree, but even so seems fine.
kali-shade
pushed a commit
to kali-shade/spark-kali
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #134 the default blending now uses
premultipliedAlpha. The material system of Three.js has built-in support for this, which takes care of setting the right blending function as well as providing a define in the fragment shader.This PR replaces the custom blending function and instead uses the
premultipliedAlphasetup. Additionally the uniform has been replaced with the define. This does mean that changing the flag requires a shader recompilation, though these variants are cached by Three.js. In the unlikely situation that a user repeatedly switches this flag, it should only incur a recompilation once.