Add minPixelRadius to skip splats below a given pixel radius
#184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
minPixelRadiusproperty similar to the existingmaxPixelRadius, but instead of clamping it's used for discarding. This allows very small splats to be discarded during the vertex shader.Worth noting that the pixel radius is checking against the radius after blur has been added. This does mean that when blurring splats have a minimum size and changing the blur amount impacts this minimum size. As a result the
minPixelRadiusisn't entirely independent of the blur amount. (The same of course applies tomaxPixelRadius, but is less relevant there)