Skip to content

Use getDrawingBufferSize to determine renderer size #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmarcos merged 2 commits into from
Jun 30, 2025
Merged

Use getDrawingBufferSize to determine renderer size #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6196fdc
Use `getDrawingBufferSize` to determine renderer size
mrxz Jun 27, 2025
827f442
Add workaround for WebXR on Vision Pro.
asundqui Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/SparkRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ export class SparkRenderer extends THREE.Mesh {
);
} else {
// Rendering to the canvas or WebXR
const renderSize = renderer.getSize(this.uniforms.renderSize.value);
const renderSize = renderer.getDrawingBufferSize(
this.uniforms.renderSize.value,
);
if (renderSize.x === 1 && renderSize.y === 1) {
// WebXR mode on Apple Vision Pro returns 1x1 when presenting.
// Use a different means to figure out the render size.
Expand Down