Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Changing localized release notes behavior slightly: release note keys…

… which are not tagged with an xml:lang attribute are no longer assumed to be English. So if the user has a foreign language anywhere in their preferred languages list, even if English is higher, release notes keyed to "da" will be picked before release notes not keyed to any language.
  • Loading branch information...
commit 00c5ae4a427e507bfddd4b673e71ad98820c168a 1 parent d73d833
@andymatuschak andymatuschak authored
Showing with 2 additions and 2 deletions.
  1. +2 −2 SUAppcast.m
View
4 SUAppcast.m
@@ -196,10 +196,10 @@ - (NSXMLNode *)bestNodeInNodes:(NSArray *)nodes
while ((node = [nodeEnum nextObject]))
{
lang = [[node attributeForName:@"xml:lang"] stringValue];
- [languages addObject:(lang ?: @"en")]; // Default to a key being English if no xml:lang is specified.
+ [languages addObject:(lang ?: @"")]; // Default to a key being English if no xml:lang is specified.
}
lang = [[NSBundle preferredLocalizationsFromArray:languages] objectAtIndex:0];
- i = [languages indexOfObject:(lang ?: @"en")];
+ i = [languages indexOfObject:(lang ?: @"")];
if (i == NSNotFound)
i = 0;
return [nodes objectAtIndex:i];
Please sign in to comment.
Something went wrong with that request. Please try again.