Browse files

Fixes 246469

This should fix the DSA-signing-on-tar-gzs issue. Sparkle now doesn't let NSURLDownload extract .gzips for us, which was making the data being verified different from the data being signed.
  • Loading branch information...
1 parent 5fdddae commit c9bd13213b6ff387c95928bb67efadcb4a3d2462 @andymatuschak andymatuschak committed Jul 15, 2008
Showing with 7 additions and 1 deletion.
  1. +6 −0 SUBasicUpdateDriver.m
  2. +1 −1 Sparkle.xcodeproj/project.pbxproj
View
6 SUBasicUpdateDriver.m
@@ -161,6 +161,12 @@ - (void)download:(NSURLDownload *)download didFailWithError:(NSError *)error
[self abortUpdateWithError:[NSError errorWithDomain:SUSparkleErrorDomain code:SURelaunchError userInfo:[NSDictionary dictionaryWithObjectsAndKeys:SULocalizedString(@"An error occurred while downloading the update. Please try again later.", nil), NSLocalizedDescriptionKey, [error localizedDescription], NSLocalizedFailureReasonErrorKey, nil]]];
}
+- (BOOL)download:(NSURLDownload *)download shouldDecodeSourceDataOfMIMEType:(NSString *)encodingType
+{
+ if ([encodingType isEqualToString:@"application/gzip"]) return NO;
+ return YES;
+}
+
- (void)extractUpdate
{
// DSA verification, if activated by the developer
View
2 Sparkle.xcodeproj/project.pbxproj
@@ -125,7 +125,7 @@
isa = PBXContainerItemProxy;
containerPortal = 0867D690FE84028FC02AAC07 /* Project object */;
proxyType = 1;
- remoteGlobalIDString = 8DC2EF4F0486A6940098B216 /* Sparkle */;
+ remoteGlobalIDString = 8DC2EF4F0486A6940098B216;
remoteInfo = Sparkle;
};
DAAEFD4F0DA572460051E0D0 /* PBXContainerItemProxy */ = {

0 comments on commit c9bd132

Please sign in to comment.