Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Apr 29, 2012
  1. @andymatuschak

    Fixes #169: Security Issue in Parsing XML using NSXMLDocument

    andymatuschak authored
    External entities are no longer parsed in appcasts: pre-10.7, we use the
    "tidy" option for XML document parsing, which happens to behave this way,
    and in 10.7+ we use a new explicit option for this behavior.
Commits on Jan 18, 2012
  1. @andymatuschak
Commits on May 2, 2011
  1. @uliwitness
Commits on Apr 28, 2010
  1. @andymatuschak

    Fixing ridiculous error in the last commit caused by non-initializati…

    andymatuschak authored
    …on of a variable. See bug #571486. Sorry about that, all.
  2. @andymatuschak

    Added an extra null check to SUAppcast downloadDidFinish because NSXM…

    andymatuschak authored
    …LDocument and NSFileManager throw exceptions on nil arguments. See bug 456514.
Commits on Mar 28, 2010
  1. @andymatuschak

    Landing delta-updates.

    andymatuschak authored
Commits on Jan 11, 2010
  1. @andymatuschak
  2. @andymatuschak

    Merge commit 'bdash/delta-updates'

    andymatuschak authored
    This is a big one, guys. Haven't tested the new features in the merged branch yet.
  3. @andymatuschak
Commits on Jan 1, 2010
  1. all but a few places use the typical [[[foo alloc] init] autorelease]…

    Sean McBride authored
    … pattern, removed 3 explicit releases and use autorelease instead. There are now only 2 exceptions to this pattern left. One is probably justified, the other looks like a leak.
Commits on Dec 21, 2009
  1. @andymatuschak
Commits on Dec 11, 2009
  1. Merge remote branch 'andymatuschak/master'

    Uli Kusterer authored
Commits on Dec 10, 2009
  1. @andymatuschak
Commits on Dec 7, 2009
  1. @uliwitness
Commits on Dec 4, 2009
  1. @uliwitness

    Merge of changes from SVN repository:

    uliwitness authored
    - Changed NTSynchronousTask to also give the status return value and direct stderror output to the outputData.
    - Changed includes so this builds as part of an app, too, not just as a framework
    - Made sure SUAppcast's dealloc releases some leaked ivars.
    - Added infoURL, extracted from link, that can point to a "more Info" page for download-less URLs
    - Added support for version attribute on item so we can support update notifications that don't include an enclosure (e.g. paid upgrades, or upgrades that would require a system update)
    - Added/improved a few description methods to ease debugging.
    - Added SULog so one can ask for a special log with additional information when there are update issues.
    - Added mayUpdateAndRestart for apps that absolutely, positively can't restart right now (e.g. cuz they're burning a CD and would produce a coaster).
    - Added updaterWillRelaunchApplication delegate method, analogous to the notification. Useful to have app delegate quit helper apps during installation.
    - Made SUBasicUpdateDriver's abortUpdate implicitly retain/autorelease the update driver, because the notification center otherwise releases it and it goes away, causing crashes in superclass's abortUpdate.
    - Merge of SUKeepDownloadOnFailedInstallKey and SUFixedHTMLDisplaySizeKey.
    - Avoid a few warnings about missing prototypes
    - Be paranoid, hdiutil can verify the download again, so let it. Better for internal apps where we turn off DSA checks, too.
    - SUHost has an -installationPath now, independent from the bundlePath, so one can normalize the app name from "MyApp 1.1b4" back to "MyApp" Users assume the file name contains the correct version number when there is one in it. Saves support a few round-trips each time.
    - Be better at threading: Try calling non-thread-safe methods on main thread only, and don't assume delegates know when they need to be thread-safe, call them on main thread where possible.
    - Added a method to put the old copy of the app in the trash. 1.5git changed in this spot, so I didn't actually merge the code that uses it back in yet.
    - Fix version comparison so it doesn't get confused by bracketed build numbers in version strings
    - Make sure cancel button is disabled during extraction, otherwise user would crash.
    - Don't put auto-update window at floating window level. It's huge and can't be switched to background! If you're an NSBGOnly where you need that, turn it on only in that case, but don't generally do such nonsense.
    - Hide release notes view if there aren't any.
    - Test whether we are on dial-up before checking for updates in background. It's not nice to cause (possibly expensive) dial-up periodically.
    - Temporarily comment out DSA complaints for easier testing.
    - Don't store (possibly already invalidated) one-shot NSTimers in an ivar. It's bad style. Retain it instead.
    - Decompress some monster expressions with nested method calls in ternary operators and nested in method calls again.
    - Don't use implicit "id" for params or return types.
    - finish_installation now puts up a progress window, so user knows update is still not finished.
    - Use ThreadSafePreferences (included dummy version that uses regular prefs for projects that don't use ThreadSafePreferences).
    - Todo later: Change finish_installation to be prettier.
Commits on Nov 1, 2009
  1. performed a code review, specifically:

    Sean McBride authored
    - changed some #include to #import
    - fixed some NULL -> nil Cocoa coding conventions
    - added new compiler warnings and fixed some warnings they generated
    - check for nil from NSTemporaryDirectory
    - added missing files to unit test and test app targets
    - added xcconfig files for unit test target
    - added @private to some ivars
    - changes some variables from signed to unsigned as appropriate
    - changed from base 2 to base 10 measurements of file size, consistent with both the actual meaning of metric prefixes and Apple's new policy as of 10.6
    - reduced some unneeded copy-paste of code
    - fixed failure to check for null from malloc and unneeded check against null before calling free
    - OSErr was incorrectly used instead of OSStatus
    - added some consts & statics to global strings
    - fixed some issues discovered by static analysis
    - fixed some 64bit issues, mostly related to casting and the use of slightly incorrect types/sizes
    - some dealloc methods were using accessors, changed to access ivars directly, as per Apple guidelines
    - removed old NS_DURING, NS_HANDLER, NS_ENDHANDLER macros
    - fixed a bug where immutable data was being mutated
    - removed all instance of "== YES" as they are dangerous
    - removed some redundant nil checks
    - fixed some leaks
    - conditionally replaced deprecated method usage
    - cleanup CF/NSMakeCollectable usage
    - fixed bug in GC where memory could be collected too early due to lack of strong references when using UTF8String
    - prevent passing null to CFRelease
Commits on Oct 20, 2009
  1. @andymatuschak
Commits on Sep 7, 2009
  1. @nevyn @andymatuschak

    When failing to parse a feed item, tell the developer *what* the erro…

    nevyn authored andymatuschak committed
    …r is. No need for a full-fledged NSError because these errors only go to the console, not displayed to the user (who doesn't care).
Commits on Sep 2, 2009
  1. Change availability checks so that they build on 10.4

    Stuart Morgan authored
Commits on Aug 21, 2009
  1. Merge branch 'master' into delta-updates

    Mark Rowe authored
  2. Add support for parsing an extended <sparkle:deltas> element in the a…

    Mark Rowe authored
    …ppcast that describes
    the delta updates that are available for a given version.
    The appcast would look a little something like the following:
    <enclosure url=" Great App" sparkle:version="2.0" length="1623481" type="application/octet-stream" sparkle:dsaSignature="BAFJW4B6B1K1JyW30nbkBwainOzrN6EQuAh" />
        <enclosure url=" Great App 1.5 to" sparkle:version="2.0" sparkle:deltaFrom="1.5" length="642381" type="application/octet-stream" sparkle:dsaSignature="MCa1JyW30nbkBwaC0CFBfeinOzrN6EQuAh=" />
        <enclosure url=" Great App 1.4 to" sparkle:version="2.0" sparkle:deltaFrom="1.4" length="928231" type="application/octet-stream" sparkle:dsaSignature="B6B1K1JyW30nbkBDBfeinOAszrN6Ea1JyW3" />
Commits on Jun 20, 2009
  1. @andymatuschak

    Removed SL-deprecated NSFileManager methods. Left the old ones around…

    andymatuschak authored
    … #if'd for 10.4 support; I look forward to removing them. :)
    Thanks for the patch, August.
Commits on Jun 15, 2009
  1. added #ifdef's for Tiger support

    August Joki authored
  2. Fixed deprecated APIs to use replacements.

    August Joki authored
Commits on Dec 24, 2008
  1. @andymatuschak

    Bug #275309: Crash in NSURLConnection

    andymatuschak authored
    This one's a little experimental. Credits to Hofman for the patch. This changes the appcast fetching over to NSURLDownload from NSURLConnection. Test, please!
Commits on Aug 17, 2008
  1. @andymatuschak

    Fixes 258060

    andymatuschak authored
    Fixed a couple memory leaks. Thanks to Christiaan Hofman for the patch.
Commits on Aug 11, 2008
  1. @andymatuschak

    Fixes 256106

    andymatuschak authored
    Sparkle will no longer break on nil XML nodes; that would occur when a node is commented out. Thanks to Christiaan Hofman for the patch.
Commits on Aug 5, 2008
  1. @andymatuschak

    Changing localized release notes behavior slightly: release note keys…

    andymatuschak authored
    … which are not tagged with an xml:lang attribute are no longer assumed to be English. So if the user has a foreign language anywhere in their preferred languages list, even if English is higher, release notes keyed to "da" will be picked before release notes not keyed to any language.
Commits on Aug 1, 2008
  1. @andymatuschak

    Fixes 252986

    andymatuschak authored
    Adds support for xml:lang to pick localized nodes in appcasts (for release notes, etc)
Commits on Jul 9, 2008
  1. @andymatuschak
Commits on Jul 3, 2008
  1. @andymatuschak

    Fixes 244419

    andymatuschak authored
    Now removing the RSS class and and NSString+extras to be replaced by a much simpler implementation based on NSXMLDocument directly in SUAppcast! But this will probably break things for certain edge-case appcasts, so please file bugs if things no longer work for you.
    Thanks to Christiaan Hofman for the patch!
Commits on Jul 1, 2008
  1. @andymatuschak
  2. @andymatuschak

    Fixed 243883:

    andymatuschak authored
    Removed the last @try/@catch from my code. Thanks to Christiaan Hofman for the patch.
Commits on Jun 21, 2008
  1. @andymatuschak

    Fixed all setters to eliminate the possibility of accidentally releas…

    andymatuschak authored
    …ing the value to be set in the case that [foo setValue:a] is called when [foo value] == a.
Commits on Jun 16, 2008
  1. @andymatuschak

    Fixes 240274

    andymatuschak authored
    Sparkle no longer crashes when the appcast contains an enclosure with no URL (or if there's any other exception in appcast parsing).
Something went wrong with that request. Please try again.