Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on May 28, 2012
  1. Fixes #44: maximumSystemVersion key

    Stefan Hoffmann authored
Commits on May 9, 2012
  1. @andymatuschak
Commits on May 2, 2011
  1. @uliwitness
Commits on Nov 26, 2010
  1. @andymatuschak
Commits on Jun 21, 2010
  1. @danielpunkass @andymatuschak
Commits on Feb 21, 2010
  1. @uliwitness

    Restore support for enclosure-less appcast items. If they have a spar…

    uliwitness authored
    …ke:version tag at the same level as the enclosure would be (as opposed to as an attribute on the enclosure), and no enclosure, but a "link" tag, the link tag's contents will be used as the URL for a "More Info" button to replace the "install" button.
    Use this for paid updates, where you want to redirect users to your store page instead of installing an update they don't have a license key for.
Commits on Jan 11, 2010
  1. @andymatuschak

    Merge commit 'bdash/delta-updates'

    andymatuschak authored
    This is a big one, guys. Haven't tested the new features in the merged branch yet.
Commits on Dec 8, 2009
Commits on Dec 7, 2009
  1. @uliwitness
Commits on Dec 4, 2009
  1. @uliwitness

    Merge of changes from SVN repository:

    uliwitness authored
    - Changed NTSynchronousTask to also give the status return value and direct stderror output to the outputData.
    - Changed includes so this builds as part of an app, too, not just as a framework
    - Made sure SUAppcast's dealloc releases some leaked ivars.
    - Added infoURL, extracted from link, that can point to a "more Info" page for download-less URLs
    - Added support for version attribute on item so we can support update notifications that don't include an enclosure (e.g. paid upgrades, or upgrades that would require a system update)
    - Added/improved a few description methods to ease debugging.
    - Added SULog so one can ask for a special log with additional information when there are update issues.
    - Added mayUpdateAndRestart for apps that absolutely, positively can't restart right now (e.g. cuz they're burning a CD and would produce a coaster).
    - Added updaterWillRelaunchApplication delegate method, analogous to the notification. Useful to have app delegate quit helper apps during installation.
    - Made SUBasicUpdateDriver's abortUpdate implicitly retain/autorelease the update driver, because the notification center otherwise releases it and it goes away, causing crashes in superclass's abortUpdate.
    - Merge of SUKeepDownloadOnFailedInstallKey and SUFixedHTMLDisplaySizeKey.
    - Avoid a few warnings about missing prototypes
    - Be paranoid, hdiutil can verify the download again, so let it. Better for internal apps where we turn off DSA checks, too.
    - SUHost has an -installationPath now, independent from the bundlePath, so one can normalize the app name from "MyApp 1.1b4" back to "MyApp" Users assume the file name contains the correct version number when there is one in it. Saves support a few round-trips each time.
    - Be better at threading: Try calling non-thread-safe methods on main thread only, and don't assume delegates know when they need to be thread-safe, call them on main thread where possible.
    - Added a method to put the old copy of the app in the trash. 1.5git changed in this spot, so I didn't actually merge the code that uses it back in yet.
    - Fix version comparison so it doesn't get confused by bracketed build numbers in version strings
    - Make sure cancel button is disabled during extraction, otherwise user would crash.
    - Don't put auto-update window at floating window level. It's huge and can't be switched to background! If you're an NSBGOnly where you need that, turn it on only in that case, but don't generally do such nonsense.
    - Hide release notes view if there aren't any.
    - Test whether we are on dial-up before checking for updates in background. It's not nice to cause (possibly expensive) dial-up periodically.
    - Temporarily comment out DSA complaints for easier testing.
    - Don't store (possibly already invalidated) one-shot NSTimers in an ivar. It's bad style. Retain it instead.
    - Decompress some monster expressions with nested method calls in ternary operators and nested in method calls again.
    - Don't use implicit "id" for params or return types.
    - finish_installation now puts up a progress window, so user knows update is still not finished.
    - Use ThreadSafePreferences (included dummy version that uses regular prefs for projects that don't use ThreadSafePreferences).
    - Todo later: Change finish_installation to be prettier.
Commits on Nov 1, 2009
  1. performed a code review, specifically:

    Sean McBride authored
    - changed some #include to #import
    - fixed some NULL -> nil Cocoa coding conventions
    - added new compiler warnings and fixed some warnings they generated
    - check for nil from NSTemporaryDirectory
    - added missing files to unit test and test app targets
    - added xcconfig files for unit test target
    - added @private to some ivars
    - changes some variables from signed to unsigned as appropriate
    - changed from base 2 to base 10 measurements of file size, consistent with both the actual meaning of metric prefixes and Apple's new policy as of 10.6
    - reduced some unneeded copy-paste of code
    - fixed failure to check for null from malloc and unneeded check against null before calling free
    - OSErr was incorrectly used instead of OSStatus
    - added some consts & statics to global strings
    - fixed some issues discovered by static analysis
    - fixed some 64bit issues, mostly related to casting and the use of slightly incorrect types/sizes
    - some dealloc methods were using accessors, changed to access ivars directly, as per Apple guidelines
    - removed old NS_DURING, NS_HANDLER, NS_ENDHANDLER macros
    - fixed a bug where immutable data was being mutated
    - removed all instance of "== YES" as they are dangerous
    - removed some redundant nil checks
    - fixed some leaks
    - conditionally replaced deprecated method usage
    - cleanup CF/NSMakeCollectable usage
    - fixed bug in GC where memory could be collected too early due to lack of strong references when using UTF8String
    - prevent passing null to CFRelease
Commits on Sep 7, 2009
  1. @nevyn @andymatuschak

    When failing to parse a feed item, tell the developer *what* the erro…

    nevyn authored andymatuschak committed
    …r is. No need for a full-fledged NSError because these errors only go to the console, not displayed to the user (who doesn't care).
Commits on Aug 21, 2009
  1. Add support for parsing an extended <sparkle:deltas> element in the a…

    Mark Rowe authored
    …ppcast that describes
    the delta updates that are available for a given version.
    The appcast would look a little something like the following:
    <enclosure url=" Great App" sparkle:version="2.0" length="1623481" type="application/octet-stream" sparkle:dsaSignature="BAFJW4B6B1K1JyW30nbkBwainOzrN6EQuAh" />
        <enclosure url=" Great App 1.5 to" sparkle:version="2.0" sparkle:deltaFrom="1.5" length="642381" type="application/octet-stream" sparkle:dsaSignature="MCa1JyW30nbkBwaC0CFBfeinOzrN6EQuAh=" />
        <enclosure url=" Great App 1.4 to" sparkle:version="2.0" sparkle:deltaFrom="1.4" length="928231" type="application/octet-stream" sparkle:dsaSignature="B6B1K1JyW30nbkBDBfeinOAszrN6Ea1JyW3" />
Commits on Aug 17, 2008
  1. @andymatuschak

    Renamed SUAppcastItem's "description" key to "itemDescription" so as …

    andymatuschak authored
    …not to conflict with the standard Cocoa description method.
Commits on Jul 29, 2008
  1. @andymatuschak

    Fixes 251963

    andymatuschak authored
    SUAppcastItem now copies the properties dictionary it's given for safety.
Commits on Jul 1, 2008
  1. @andymatuschak

    Fixed 243883:

    andymatuschak authored
    Removed the last @try/@catch from my code. Thanks to Christiaan Hofman for the patch.
Commits on Jun 21, 2008
  1. @andymatuschak

    Fixed all setters to eliminate the possibility of accidentally releas…

    andymatuschak authored
    …ing the value to be set in the case that [foo setValue:a] is called when [foo value] == a.
Commits on May 31, 2008
  1. @andymatuschak

    Fixes bug 228446

    andymatuschak authored
    Finally adding real delegate support. The following methods are implemented; the comments document them.
    If you have suggestions for other methods that would be useful, feel free to suggest them.
    // Use this to override the default behavior for Sparkle prompting the user about automatic update checks.
    - (BOOL)shouldPromptForPermissionToCheckForUpdates;
    // Implement this if you want to do some special handling with the appcast once it finishes loading.
    - (void)appcastDidFinishLoading:(SUAppcast *)appcast;
    // If you're using special logic or extensions in your appcast, implement this to use your own logic for finding
    // a valid update, if any, in the given appcast.
    - (SUAppcastItem *)bestValidUpdateInAppcast:(SUAppcast *)appcast;
    // Sent when a valid update is found by the update driver.
    - (void)didFindValidUpdate:(SUAppcastItem *)update;
    // Sent when the user makes a choice in the update alert dialog (install now / remind me later / skip this version).
    - (void)userChoseAction:(SUUpdateAlertChoice)action forUpdate:(SUAppcastItem *)update;
    // Sent immediately before installing the specified update.
    - (void)updateWillInstall:(SUAppcastItem *)update;
    // Return YES to delay the relaunch until you do some processing; invoke the given NSInvocation to continue.
    - (BOOL)shouldPostponeRelaunchForUpdate:(SUAppcastItem *)update untilInvoking:(NSInvocation *)invocation;
    // Called immediately before relaunching.
    - (void)updaterWillRelaunchApplication;
Commits on May 8, 2008
  1. Touched practically every line of code in a super-monster-awesome ref…

    andym authored
    …actoring. Please read:
    - Broke out SUUpdater functionality into update drivers. There's a basic one from which everything else inherits, then a user-initiated one, an automatic one, and a scheduled one. It's super-clean-and-shiny.
    - Destroyed the abomination that was SUStatusChecker. In its place is SUProbingUpdateDriver, which is like 10 lines long.
    - Made automatic installation less stupid. It used to install, THEN offer to relaunch. That's dumb, beacuse if the user says no, the app is running from the trash. Now it offers to install and relaunch or to install on quit.
    - Renamed like every method and symbol. I hope you didn't branch anything.
    - Reorganized the project hierarchy to be much clearer and easier to navigate.
    - Reworked the error system to no use NSError instead of exceptions; extra technical information is now logged to the console so that we can find problems.
    - A bunch of other small bugfixes in things I noticed along the way but no longer remember.
    - Probably a ton of other stuff.
    Read over the code and see what I've done. Then PLEASE test this with your app internally and let me know how it goes. This revision is hereby NOT YET DECLARED SAFE FOR PUBLIC RELEASE. But because I'm still using SVN, this is how things have to be.
Commits on Jan 19, 2008
  1. Another change to support [109].

    andym authored
Commits on Jan 14, 2008
Commits on Dec 25, 2007
  1. Improved headers from Charles D. H. Williams.

    andym authored
Commits on Dec 24, 2007
  1. Fixed up headers to make things easier for those who compile Sparkle …

    andym authored
    …in situ -- thanks for the help, Charles D. H. Williams.
Commits on Jul 10, 2007
Something went wrong with that request. Please try again.