Commits on Feb 11, 2012
  1. Support a custom user defaults domain

    mattstevens committed Feb 11, 2012
    This is useful for situations like a background app that updates a
    parent preference pane but wants to maintain defaults in the background
    app's domain.
Commits on Oct 4, 2011
  1. Merging "ulimerge," which contains a great number of changes and cont…

    andymatuschak committed Oct 4, 2011
    …ributions from Uli Kusterer, Elgato, and other contributors.
    - appcast entries with a "new version" but without a download (paid updates, update notification for users of dropped HW)
    - installation now happens in a tool, rather than in the app being replaced
    - Sparkle-related logs now separated into a separate file ~/Library/Logs/SparkleUpdateLog.log for easier QA/triage
    - tons of small bug fixes
    - more details at #18
Commits on May 27, 2011
  1. Added a new Info.plist key: SUPromptUserOnFirstLaunch. Set this to YE…

    andymatuschak committed May 27, 2011
    …S to disable Sparkle's usual behavior of waiting 'till the second launch of an app to prompt for update permission.
    This is useful for apps which don't, under normal operations, get quit. Like a menu extra.
Commits on May 2, 2011
Commits on Dec 4, 2009
  1. Merge of changes from SVN repository:

    uliwitness committed Dec 4, 2009
    - Changed NTSynchronousTask to also give the status return value and direct stderror output to the outputData.
    - Changed includes so this builds as part of an app, too, not just as a framework
    - Made sure SUAppcast's dealloc releases some leaked ivars.
    - Added infoURL, extracted from link, that can point to a "more Info" page for download-less URLs
    - Added support for version attribute on item so we can support update notifications that don't include an enclosure (e.g. paid upgrades, or upgrades that would require a system update)
    - Added/improved a few description methods to ease debugging.
    - Added SULog so one can ask for a special log with additional information when there are update issues.
    - Added mayUpdateAndRestart for apps that absolutely, positively can't restart right now (e.g. cuz they're burning a CD and would produce a coaster).
    - Added updaterWillRelaunchApplication delegate method, analogous to the notification. Useful to have app delegate quit helper apps during installation.
    - Made SUBasicUpdateDriver's abortUpdate implicitly retain/autorelease the update driver, because the notification center otherwise releases it and it goes away, causing crashes in superclass's abortUpdate.
    - Merge of SUKeepDownloadOnFailedInstallKey and SUFixedHTMLDisplaySizeKey.
    - Avoid a few warnings about missing prototypes
    - Be paranoid, hdiutil can verify the download again, so let it. Better for internal apps where we turn off DSA checks, too.
    - SUHost has an -installationPath now, independent from the bundlePath, so one can normalize the app name from "MyApp 1.1b4" back to "MyApp" Users assume the file name contains the correct version number when there is one in it. Saves support a few round-trips each time.
    - Be better at threading: Try calling non-thread-safe methods on main thread only, and don't assume delegates know when they need to be thread-safe, call them on main thread where possible.
    - Added a method to put the old copy of the app in the trash. 1.5git changed in this spot, so I didn't actually merge the code that uses it back in yet.
    - Fix version comparison so it doesn't get confused by bracketed build numbers in version strings
    - Make sure cancel button is disabled during extraction, otherwise user would crash.
    - Don't put auto-update window at floating window level. It's huge and can't be switched to background! If you're an NSBGOnly where you need that, turn it on only in that case, but don't generally do such nonsense.
    - Hide release notes view if there aren't any.
    - Test whether we are on dial-up before checking for updates in background. It's not nice to cause (possibly expensive) dial-up periodically.
    - Temporarily comment out DSA complaints for easier testing.
    - Don't store (possibly already invalidated) one-shot NSTimers in an ivar. It's bad style. Retain it instead.
    - Decompress some monster expressions with nested method calls in ternary operators and nested in method calls again.
    - Don't use implicit "id" for params or return types.
    - finish_installation now puts up a progress window, so user knows update is still not finished.
    - Use ThreadSafePreferences (included dummy version that uses regular prefs for projects that don't use ThreadSafePreferences).
    - Todo later: Change finish_installation to be prettier.
Commits on Nov 1, 2009
  1. performed a code review, specifically:

    Sean McBride Sean McBride
    Sean McBride authored and Sean McBride committed Nov 1, 2009
    - changed some #include to #import
    - fixed some NULL -> nil Cocoa coding conventions
    - added new compiler warnings and fixed some warnings they generated
    - check for nil from NSTemporaryDirectory
    - added missing files to unit test and test app targets
    - added xcconfig files for unit test target
    - added @private to some ivars
    - changes some variables from signed to unsigned as appropriate
    - changed from base 2 to base 10 measurements of file size, consistent with both the actual meaning of metric prefixes and Apple's new policy as of 10.6
    - reduced some unneeded copy-paste of code
    - fixed failure to check for null from malloc and unneeded check against null before calling free
    - OSErr was incorrectly used instead of OSStatus
    - added some consts & statics to global strings
    - fixed some issues discovered by static analysis
    - fixed some 64bit issues, mostly related to casting and the use of slightly incorrect types/sizes
    - some dealloc methods were using accessors, changed to access ivars directly, as per Apple guidelines
    - removed old NS_DURING, NS_HANDLER, NS_ENDHANDLER macros
    - fixed a bug where immutable data was being mutated
    - removed all instance of "== YES" as they are dangerous
    - removed some redundant nil checks
    - fixed some leaks
    - conditionally replaced deprecated method usage
    - cleanup CF/NSMakeCollectable usage
    - fixed bug in GC where memory could be collected too early due to lack of strong references when using UTF8String
    - prevent passing null to CFRelease
Commits on Sep 10, 2008
  1. More security tidbits!

    andymatuschak committed Sep 10, 2008
    This patch prevents malicious downgrades, which are still possible with DSA validation: suppose there's some (signed) version with a security hole. A malicious attacker could serve an appcast with that version's URL and DSA signature, but a higher version number, forcing the user to "upgrade" to the version with the security hole.
    While I was at it, I fixed a bug that should have completely stopped .pkg installation from working since 1.5b1. Why didn't I hear anything about that? Does anyone actually use .pkgs? It still needs testing to be sure it works.
Commits on Jul 30, 2008
Commits on May 31, 2008
  1. Fixes bug 228454.

    andymatuschak committed May 31, 2008
    Added support for a SUPublicDSAKeyFile, so people don't have to copy/paste their entire DSA public key into their Info.plist.
    Basically: specify a filename in your Info.plist under the key SUPublicDSAKeyFile, and Sparkle will look for a file of that name in the app's resources directory and load its contents to use as the DSA public key.
Commits on May 9, 2008
  1. Sparkle now migrates SUCheckAtStartup preferences from pre-startup-re…

    andymatuschak committed May 9, 2008
    …factoring. Thanks to Jonas Witt for the patch.
Commits on May 8, 2008
  1. Touched practically every line of code in a super-monster-awesome ref…

    andym committed May 8, 2008
    …actoring. Please read:
    - Broke out SUUpdater functionality into update drivers. There's a basic one from which everything else inherits, then a user-initiated one, an automatic one, and a scheduled one. It's super-clean-and-shiny.
    - Destroyed the abomination that was SUStatusChecker. In its place is SUProbingUpdateDriver, which is like 10 lines long.
    - Made automatic installation less stupid. It used to install, THEN offer to relaunch. That's dumb, beacuse if the user says no, the app is running from the trash. Now it offers to install and relaunch or to install on quit.
    - Renamed like every method and symbol. I hope you didn't branch anything.
    - Reorganized the project hierarchy to be much clearer and easier to navigate.
    - Reworked the error system to no use NSError instead of exceptions; extra technical information is now logged to the console so that we can find problems.
    - A bunch of other small bugfixes in things I noticed along the way but no longer remember.
    - Probably a ton of other stuff.
    Read over the code and see what I've done. Then PLEASE test this with your app internally and let me know how it goes. This revision is hereby NOT YET DECLARED SAFE FOR PUBLIC RELEASE. But because I'm still using SVN, this is how things have to be.
Commits on Apr 15, 2008
  1. Major refactoring, yay.

    andym committed Apr 15, 2008
    Moved out installation phase to separate classes, separating packages and flat-file installs.
    Made the DMG cleanup less horrifying.
    All-around prettification.
    This may or may not break the world; please let me know.
Commits on Feb 15, 2008
  1. Finished integrating SparklePlus profiling! Just set SUEnableSystemPr…

    andym committed Feb 15, 2008
    …ofiling to YES in your info.plist. The Test App has this on by default so you all can see.
Commits on Jan 24, 2008
  1. Made a good deal more progress integrating the profile checking featu…

    andym committed Jan 24, 2008
    …res. It should actually work now.
    Interface for asking the user if they will allow the profile to be sent is forthcoming.
    I also added some debug options to the test app's window; these may come in handy.
Commits on Dec 30, 2007
  1. Fixed warnings for missing newlines at the end of the file.

    andym committed Dec 30, 2007
    Replaced use of SystemVersion.plist with Gestalt()
Commits on Dec 25, 2007
  1. Improved headers from Charles D. H. Williams.

    andym committed Dec 25, 2007
Commits on Dec 24, 2007
  1. Fixed up headers to make things easier for those who compile Sparkle …

    andym committed Dec 24, 2007
    …in situ -- thanks for the help, Charles D. H. Williams.
Commits on Dec 22, 2007
  1. Substantial changes made to how Sparkle works on startup now. SUCheck…

    andym committed Dec 22, 2007
    …AtStartup is dead, as are checks on startup. Now Sparkle asks if it can check for updates automatically and does so according to the scheduled check interval, which defaults to a day. Additionally -- THIS IS IMPORTANT -- Sparkle won't prompt the user on the first launch. It waits until the second to improve the first-use experience.
Commits on Nov 11, 2007
  1. #77 SUIgnoreChecks to ignore update, needed for Sparkle in large dep…

    catlan committed Nov 11, 2007
Commits on Jul 10, 2007