Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Nov 1, 2009
  1. performed a code review, specifically:

    Sean McBride authored
    - changed some #include to #import
    - fixed some NULL -> nil Cocoa coding conventions
    - added new compiler warnings and fixed some warnings they generated
    - check for nil from NSTemporaryDirectory
    - added missing files to unit test and test app targets
    - added xcconfig files for unit test target
    - added @private to some ivars
    - changes some variables from signed to unsigned as appropriate
    - changed from base 2 to base 10 measurements of file size, consistent with both the actual meaning of metric prefixes and Apple's new policy as of 10.6
    - reduced some unneeded copy-paste of code
    - fixed failure to check for null from malloc and unneeded check against null before calling free
    - OSErr was incorrectly used instead of OSStatus
    - added some consts & statics to global strings
    - fixed some issues discovered by static analysis
    - fixed some 64bit issues, mostly related to casting and the use of slightly incorrect types/sizes
    - some dealloc methods were using accessors, changed to access ivars directly, as per Apple guidelines
    - removed old NS_DURING, NS_HANDLER, NS_ENDHANDLER macros
    - fixed a bug where immutable data was being mutated
    - removed all instance of "== YES" as they are dangerous
    - removed some redundant nil checks
    - fixed some leaks
    - conditionally replaced deprecated method usage
    - cleanup CF/NSMakeCollectable usage
    - fixed bug in GC where memory could be collected too early due to lack of strong references when using UTF8String
    - prevent passing null to CFRelease
Commits on Jul 16, 2008
  1. @andymatuschak

    Beginnings of insane SUHost-based refactoring to get rid of NSBundle+…

    andymatuschak authored
    …Sparkle. More super-unstable refactorings to come...
Commits on Jun 29, 2008
  1. @andymatuschak

    Fixing 241181

    andymatuschak authored
    Added a cancel button to the "checking for updates..." dialog.
Commits on May 31, 2008
  1. @andymatuschak

    Fixes bug 236235.

    andymatuschak authored
    Sparkle now gies visual indication that it's checking for updates when hte update's user initiated. ie: it pops up a status controller saying "checking for updates..."
    What was SUUserInitiatedUpdateDriver is now SUUIBasedUpdateDriver; SUUserInitiatedUpdateDriver now is a subclass of that, along with SUScheduledUpdateDriver. This is a happy little refactoring that let me remove some redundant code.
Commits on Feb 14, 2008
  1. Added SUWindowController to reduce duplication of running-in-bundle s…

    andym authored
    …pecial-case code.
Commits on Jan 14, 2008
Commits on Dec 30, 2007
  1. Fixed warnings for missing newlines at the end of the file.

    andym authored
    Replaced use of SystemVersion.plist with Gestalt()
Commits on Dec 25, 2007
  1. Improved headers from Charles D. H. Williams.

    andym authored
Commits on Dec 24, 2007
  1. Fixed up headers to make things easier for those who compile Sparkle …

    andym authored
    …in situ -- thanks for the help, Charles D. H. Williams.
Commits on Dec 22, 2007
  1. Beware of falling bricks! Huge refactoring commit #1: cleansing Spark…

    andym authored
    …le of the plague that was SUUtilities.
Commits on Dec 2, 2007
  1. Finally got DMGs working properly on 10.5 through a somewhat less bri…

    andym authored
    …ttle method - ie, no more internetenable. Thanks to Steve Gehrman from CocoaTech.
    Also fixed a bug with the host app extension method, the recursive find-the-app-in-the-archive method, and made the extension comparison case insensitive for extraction purposes.
Commits on Nov 9, 2007
  1. #76 Support for Plug-ins

    catlan authored
Commits on Jul 10, 2007
Something went wrong with that request. Please try again.