Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Sep 10, 2008
  1. @andymatuschak

    Fixed a potential security vulnerability in which the download is tra…

    andymatuschak authored
    …nsmitted over SSL but is from a malicious server. Now the download has to be transmitted over SSL *and* the download's host has to be the same as the appcast's.
Commits on Sep 4, 2008
  1. Don't use unicode in NSString literals

    Stuart Morgan authored
Commits on Jul 24, 2008
  1. @andymatuschak

    Fixes 243884

    andymatuschak authored
    Made Sparkle.h no longer a massive multi-headed abomination: now only SUAppcastItem, SUAppcast and SUUpdater (and SUVersionComparisonProtocol because it's part of the delegate protocol) are public.
    
    COMPATIBILITY ISSUE:
    This means there's no longer a public SUProbingUpdateDriver or a checkForUpdatesWithDriver: method. Now use checkForUpdateInformation. I may change that API before release, though. I'm thinking it might be better to give the delegate the opportunity to reject a potential update instead: then you'd just call checkForUpdatesInBackground and override that delegate method to always return NO. We'll see.
  2. @andymatuschak
Commits on Jul 23, 2008
  1. @andymatuschak

    Fixed 251010

    andymatuschak authored
    Fixes from Matt Stevens:
    "For background applications (menu bar, completely UI-less, etc) there are a couple of issues with Sparkle notifications:
    
    - When prompts such as the initial prompt to enable update checking are displayed they can be hidden behind other windows since the background app is not in focus. This can cause problems, as these prompts run modally and can stop the application from functioning without the user knowing why.
    
    - If the update notification window is displayed and the user clicks away to another application, the window disappears and there is no way to get it back since there is no other UI to cause the app to activate. In this case the update should probably operate as a standard window since it is effectively operating as the application's UI."
  2. @mattstevens
Commits on Jul 17, 2008
  1. @andymatuschak

    Fixes 248929, 244738

    andymatuschak authored
    Removed NSWorkspace+RBAdditions: we're now checking if the volume is read-only instead of specifically whether it's a disk image.
    
    This also means the warning string changed. Sorry, localizers!
  2. @andymatuschak
Commits on Jul 16, 2008
  1. @andymatuschak
  2. @andymatuschak

    Beginnings of insane SUHost-based refactoring to get rid of NSBundle+…

    andymatuschak authored
    …Sparkle. More super-unstable refactorings to come...
  3. @andymatuschak

    Hopefully finally fixing 245744; it wasn't fixed by the previous revi…

    andymatuschak authored
    …sion that claimed it was. There was a tricksy subclassing nuance that eluded me.
Commits on Jul 9, 2008
  1. @andymatuschak
Commits on Jul 5, 2008
  1. @andymatuschak

    Fixes 245744

    andymatuschak authored
    Fixed a bug where the user-initiated updater could abort through abnormal means, making the "checking for updates..." window never able to go away.
Commits on Jun 29, 2008
  1. @andymatuschak

    Fixing 241181

    andymatuschak authored
    Added a cancel button to the "checking for updates..." dialog.
  2. @andymatuschak
Commits on Jun 21, 2008
  1. @andymatuschak
Commits on Jun 16, 2008
  1. @andymatuschak
Commits on May 31, 2008
  1. @andymatuschak

    Fixes bug 236235.

    andymatuschak authored
    Sparkle now gies visual indication that it's checking for updates when hte update's user initiated. ie: it pops up a status controller saying "checking for updates..."
    
    What was SUUserInitiatedUpdateDriver is now SUUIBasedUpdateDriver; SUUserInitiatedUpdateDriver now is a subclass of that, along with SUScheduledUpdateDriver. This is a happy little refactoring that let me remove some redundant code.
  2. @andymatuschak

    Moved the check for whether the host is running from a disk image to …

    andymatuschak authored
    …SUBasicUpdateDriver so that all drivers could take advantage of this check.
  3. @andymatuschak

    Sparkle now works correctly with LSUIElements: it focuses them before…

    andymatuschak authored
    … displaying the update alert. This fixes bug 228471.
Commits on May 18, 2008
  1. added formatted file size output

    Jonas Witt authored
Commits on May 13, 2008
  1. @andymatuschak

    Changed calls to longValue to calls to doubleValue; using the former …

    andymatuschak authored
    …is potentially a problem when something's saved as an NSString when we expect an NSNumber. This'll handle both cases.
Commits on May 8, 2008
  1. Touched practically every line of code in a super-monster-awesome ref…

    andym authored
    …actoring. Please read:
    
    - Broke out SUUpdater functionality into update drivers. There's a basic one from which everything else inherits, then a user-initiated one, an automatic one, and a scheduled one. It's super-clean-and-shiny.
    - Destroyed the abomination that was SUStatusChecker. In its place is SUProbingUpdateDriver, which is like 10 lines long.
    - Made automatic installation less stupid. It used to install, THEN offer to relaunch. That's dumb, beacuse if the user says no, the app is running from the trash. Now it offers to install and relaunch or to install on quit.
    - Renamed like every method and symbol. I hope you didn't branch anything.
    - Reorganized the project hierarchy to be much clearer and easier to navigate.
    - Reworked the error system to no use NSError instead of exceptions; extra technical information is now logged to the console so that we can find problems.
    - A bunch of other small bugfixes in things I noticed along the way but no longer remember.
    - Probably a ton of other stuff.
    Read over the code and see what I've done. Then PLEASE test this with your app internally and let me know how it goes. This revision is hereby NOT YET DECLARED SAFE FOR PUBLIC RELEASE. But because I'm still using SVN, this is how things have to be.
Something went wrong with that request. Please try again.