Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error dialog when running from read-only volume should move second sentence to NSLocalizedRecoverySuggestionErrorKey #1515

Open
quinntaylor opened this issue Dec 12, 2019 · 2 comments
Labels
1.x

Comments

@quinntaylor
Copy link
Contributor

@quinntaylor quinntaylor commented Dec 12, 2019

In the alert dialog when running from read-only volume, both sentences are in bold. The second should move to non-bold text below. This is accomplished by splitting the text between localizedDescription (NSLocalizedDescriptionKey) and localizedRecoverySuggestion (NSLocalizedRecoverySuggestionErrorKey).

image

The code that creates the NSError should pass 2 localized strings for both userInfo keys, and content of the Sparkle.strings files should be updated.

quinntaylor added a commit to quinntaylor/Sparkle that referenced this issue Dec 12, 2019
…roject#1515)

• Updated error dialog code in SUBasicUpdateDriver, and created a local variable to reuse `[aHost name]`.
• Updated content of Sparkle.strings files, splitting existing affected translations into 2 chunks each.
• Changed "Use Finder to copy" to back to "Copy", since most translations still use that terminology.
• Fixed the Catalan translation, which was using an old string key.
• Removed a few unnecessary comments in the Polish translation.
@quinntaylor

This comment has been minimized.

Copy link
Contributor Author

@quinntaylor quinntaylor commented Dec 12, 2019

Pull request: #1516

@quinntaylor

This comment has been minimized.

Copy link
Contributor Author

@quinntaylor quinntaylor commented Dec 12, 2019

See also: #1192

@kornelski kornelski added the 1.x label Dec 14, 2019
quinntaylor added a commit to quinntaylor/Sparkle that referenced this issue Dec 14, 2019
…roject#1515)

• Updated error dialog code in SUBasicUpdateDriver, and created a local variable to reuse `[aHost name]`.
• Updated content of Sparkle.strings files, splitting existing affected translations into 2 chunks each.
• Fixed the Catalan translation, which was using an old string key.
• Removed a few unnecessary comments in the Polish translation.
kornelski added a commit that referenced this issue Dec 15, 2019
Fix second bold sentence in read-only update alert dialog. (#1515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.