Bug: sparkle:shortVersionString ignored for non-enclosure items #174

bdb opened this Issue May 8, 2012 · 0 comments


None yet
2 participants

bdb commented May 8, 2012

Sparkle will display the sparkle:version string in the update alert for download-less items and that string may not be fit for user display.


diff --git a/SUAppcastItem.m b/SUAppcastItem.m
index 5768055..af8da8b 100644
--- a/SUAppcastItem.m
+++ b/SUAppcastItem.m
@@ -212,6 +212,9 @@
[self setMinimumSystemVersion: [dict objectForKey:@"sparkle:minimumSystemVersion"]];

            NSString *shortVersionString = [enclosure objectForKey:@"sparkle:shortVersionString"];
  •    if (nil == shortVersionString) {
  •        shortVersionString = [dict objectForKey:@"sparkle:shortVersionString"]; // possible download-less item
  •    }
            if (shortVersionString)
                    [self setDisplayVersionString: shortVersionString];

iloveitaly added a commit to iloveitaly/Sparkle that referenced this issue Aug 5, 2012

Merge branch 'andymatuschak/master'
* andymatuschak/master: (170 commits)
  Adding Thai localizations to the project.
  Add Thai localization
  Update to the Brazilian Portuguese localization from Victor Figueriedo
  Removed Japanese localization of password prompt from the Xcode project
  Allow the user to try reentering his password if authentication fails.
  Removing Japanese localization of the password prompt, since I changed the design
  Delegated password prompting to the update driver.
  Use NSFileManager interface for DMG unarchive only for 10.7+. On 10.6,  [NSFileManager copyItemAtPath:toPath:error:] can fail with "Argument list too long" if the app bundle contains too many files. The switch to NSFileManager was only required for 10.7 anyway, 10.6 always worked fine.
  Removed changes to the project.pbxproj that were unrelated to the password prompt
  Redesigned password prompt UI
  Removed methods from SUPasswordPrompt.h that didn't need to be exposed there
  Fixes #44: maximumSystemVersion key
  remove the ASW tags since we're submitting this as a pull request to andy
  Updating Danish localization courtesy Daniel Østergaard Nielsen
  support for encrypted disk images
  Fixes #175: Bug: update alert text collides with automatic download checkbox
  Fixes #174: Bug: sparkle:shortVersionString ignored for non-enclosure items
  Fixes #170: An environment variable set by Sparkle
  Fixing some new Clang warnings from Xcode 4.4
  Fixes #169: Security Issue in Parsing XML using NSXMLDocument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment