Xcode [Redacted] Hates Uninitialized Compares

[CodaFi]

In the newest Xcode, Sparkle will not compile because SUPipedUnarchiver uses a very weird compare from a goto here:

finally:
    if (fp)
        fclose(fp);
    if (oldDestinationString)
        setenv("DESTINATION", oldDestinationString, 1);
    else
        unsetenv("DESTINATION");
    [pool release];

Which stems from some Macros tripping up the compiler here:

#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4
    NSNumber *fs = [[[NSFileManager defaultManager] fileAttributesAtPath:archivePath traverseLink:NO] objectForKey:NSFileSize];
#else
    NSNumber *fs = [[[NSFileManager defaultManager] attributesOfItemAtPath:archivePath error:nil] objectForKey:NSFileSize];
#endif

Xcode complains of "oldDestinationString being used uninitialized whenever the 'if' condition is true."

I would rather not have to do a clang diagnostic push/pop, or outright remove those statements there to get this to work.

[andymatuschak]

A legitimate complaint!