NSInternalInconsistencyException on SUAutomaticUpdateAlert for some users #237
Comments
|
Ew have the same issue, just with a different nib file: Incident Identifier: 32B25210-C8C3-4C5C-A5BB-A86E322F1530 Date/Time: 2012-12-09 18:15:15 +0000 Exception Type: SIGABRT Application Specific Information: Last Exception Backtrace: Thread 0 Crashed: Thread 1: Thread 2: Thread 3: Thread 4: Thread 5: Thread 6: Thread 7: Thread 8: Thread 9: Thread 10: Thread 11: Thread 12: Thread 13: Thread 14: Thread 0 crashed with X86 Thread State: Binary Images: |
|
NSWindowController documentation says for -initWithWindowNibPath:owner: Use this method if your nib file is at a fixed location (which is not inside either the file’s owner’s class’s bundle or in the application’s main bundle). I don't know, if this means, that the nib file is not allowed to resist either in Sparkle--Framework-Bundle or somewhere inside the main bundle. If so, this method looks rather strange and somewhat useless to me, but the nib paths we handle over to this method are on such a location. IMHO this could lead to an NSInternalInconsistencyException I changed the code in SUWindowController to -initWithWindowNibName:owner: it works fine, but I will test it more before commiting it to this repository. What is your opinion? |
|
HI, sorry its taken me so long to reply, that sounds interesting, I will look into that and try the change, I will report any findings. |
|
Hi guys, any progress on this issue? |
|
Just experienced this in our app. |
|
any sollution/update for this crash ? |
|
Having this fix in our apps for round about a year and had no issues encountered anymore. |
|
Yeah same result here, I tried the change in the latest releases and its been fine. Thats since November 2013. |
|
Is the fix for this going to be merged to master? Or has it been fixed some other way? |
reason: Invalid parameter not satisfying: windowNibPath See sparkle-project#237 (comment)
|
@bensurtees assuming all has remained well with your patched version, could you throw the patch up as a PR? Might help get this issue closed out :) |
|
@pornel I'd missed that the fix had gone in here too, but I do still seem to be getting these crashes (using Sparkle 1.10.0): |
|
I think that has been fixed some time after 1.10, so please try 1.11: https://github.com/sparkle-project/Sparkle/releases/tag/1.11.0rc1 |
|
sparkle 1.16 thank you. |
|
Do you have the text of the exception? |
|
NSInternalInconsistencyException.txt download from Fabric, thanks. |
I keep getting exception reports from users, at first I thought it was a localization issue, but I get it for some "en" users too. Any Idea what causes this, anyone else seeing it?
NSInternalInconsistencyException
Invalid parameter not satisfying: windowNibPath
(
0 CoreFoundation 0x00007fff912d9f56 exceptionPreprocess + 198
1 libobjc.A.dylib 0x00007fff9ab64d5e objc_exception_throw + 43
2 CoreFoundation 0x00007fff912d9d8a +[NSException raise:format:arguments:] + 106
3 Foundation 0x00007fff919ba71f -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 169
4 AppKit 0x00007fff8f2f7088 -[NSWindowController initWithWindowNibPath:owner:] + 141
5 Sparkle 0x0000000100071c1c -[SUWindowController initWithHost:windowNibName:] + 412
6 Sparkle 0x000000010006d674 -[SUAutomaticUpdateAlert initWithAppcastItem:host:delegate:] + 84
7 Sparkle 0x00000001000797f4 -[SUAutomaticUpdateDriver unarchiverDidFinish:] + 148
8 CoreFoundation 0x00007fff912c970d -[NSObject performSelector:withObject:] + 61
9 Sparkle 0x000000010007c01e -[SUUnarchiver(Private) notifyDelegateOfSuccess] + 110
10 CoreFoundation 0x00007fff912c970d -[NSObject performSelector:withObject:] + 61
11 Foundation 0x00007fff9193ed70 __NSThreadPerformPerform + 214
12 CoreFoundation 0x00007fff912484f1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 17
13 CoreFoundation 0x00007fff91247d5d __CFRunLoopDoSources0 + 253
14 CoreFoundation 0x00007fff9126eb49 __CFRunLoopRun + 905
15 CoreFoundation 0x00007fff9126e486 CFRunLoopRunSpecific + 230
16 HIToolbox 0x00007fff92dbc2bf RunCurrentEventLoopInMode + 277
17 HIToolbox 0x00007fff92dc356d ReceiveNextEventCommon + 355
18 HIToolbox 0x00007fff92dc33fa BlockUntilNextEventMatchingListInMode + 62
19 AppKit 0x00007fff8ec50779 _DPSNextEvent + 659
20 AppKit 0x00007fff8ec5007d -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 135
21 AppKit 0x00007fff8ec4c9b9 -[NSApplication run] + 470
22 AppKit 0x00007fff8eec8eac NSApplicationMain + 867
The text was updated successfully, but these errors were encountered: