Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Skip..." and "Remind..." buttons. #1480

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@kennethjohnsen
Copy link
Contributor

kennethjohnsen commented Oct 4, 2019

Added possibility of setting SUHideSkipButton and SUHideRemindButton.
This is useful when automatic updates are disabled, since the user will not be reminded anyway until he/she manually starts an update-check, so the buttons may confuse the user.

…/ SUHideRemindButton is set to YES in info.plist.
@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Oct 4, 2019

We've discussed this for critical updates, which is a specific context.

I see this solution solves the problem for you, but for Sparkle in general it's less beneficial, because:

  • Optional settings means existing Sparkle users don't get this functionality unless they implement it themselves,

  • Implementing it means more things in documentation, more work to integrate with Sparkle.

So while I agree with the problems you're trying to solve, I'm not convinced that such low-level specific config is the right solution.

I'd prefer the skip button to be hidden automatically for critical updates.

It's also a great catch that "remind me later" doesn't make sense for manual update checks. But in this case it also makes sense to just hide it automatically, so that all Sparkle users benefit from it out of the box, and we don't have to add documentation or extra integration work for them.

@kennethjohnsen

This comment has been minimized.

Copy link
Contributor Author

kennethjohnsen commented Oct 14, 2019

I agree that adding it as optional settings will just add more complexity.
But will all users want to have the "Skip" button hidden for critical updates?

Our requirement was to just hide the skip and remind buttons, since users of our app does not use automatic updates (they have to click a menu-item, that then checks for updates).

I can implement the following changes instead (if we are sure it's relevant for all users):

  • Hide "Remind me later" button when automatic updates are not enabled.
  • Hide "Skip this version" button when there's critical updates.

Or, since I just noticed that the other comment in #1073 is more than 2 years old, I'm not sure if @gsrinivasanbjn still need this change?

@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Oct 14, 2019

@kennethjohnsen Yes, please. I think it's sensible to do this by default, and having this behavior out of the box would be most helpful for most users.

…tomatic updates enabled.

Removed keys for setting buttons to hidden using plist entries.
Instead, the skip-button is now hidden for critical updates, and the later-button is hidden if automatic updates are disabled.
Note that the user can still choose to just close the window by clicking the red dot at the top of the window.
@kennethjohnsen

This comment has been minimized.

Copy link
Contributor Author

kennethjohnsen commented Oct 15, 2019

I changed the code accordingly.
Let me know if it meets the discussed requirements.

@kornelski kornelski merged commit 0cfedd4 into sparkle-project:master Oct 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Oct 15, 2019

Great! Thanks.

@kennethjohnsen kennethjohnsen deleted the kennethjohnsen:hide-skip-and-remind-buttons branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.