Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SUPlainInstaller.m #1512

Merged
merged 1 commit into from Dec 11, 2019
Merged

Update SUPlainInstaller.m #1512

merged 1 commit into from Dec 11, 2019

Conversation

@core-code
Copy link
Contributor

core-code commented Dec 11, 2019

Try to preserve Finder tags while updating apps

Try to preserve Finder tags while updating apps
@kornelski kornelski merged commit 1081dcd into sparkle-project:master Dec 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Dec 11, 2019

Thanks!

@core-code

This comment has been minimized.

Copy link
Contributor Author

core-code commented Dec 11, 2019

sorry to followup here but this code requires 10.9 but i just see now that you still support 10.7 (wow).

should i send another PR that wraps this in an @available block?

i don't actually think anything bad will happen on 10.7 / 10.8 but unless actual tests say its harmless we should better be correct.

@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Dec 11, 2019

Oh yes, wrapping it in a check would be good.

kornelski added a commit that referenced this pull request Dec 12, 2019
* Update SUPlainInstaller.m

Try to preserve Finder tags while updating apps

* Update SUPlainInstaller.m
kornelski added a commit that referenced this pull request Dec 13, 2019
* Update SUPlainInstaller.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.