Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .h files from Build Rules for bsdiff and ed25519 #1538

Merged
merged 1 commit into from Jan 25, 2020

Conversation

@pteeson
Copy link
Contributor

pteeson commented Jan 23, 2020

On branch VendorBuildPhasesFix
Changes to be committed:
modified: Sparkle.xcodeproj/project.pbxproj

Building the Sparkle framework produced 10 Warnings caused by .h files
being added to the Build Rules Compile Sources. Thanks to tip from
Stackoverflow https://stackoverflow.com/questions/6509600/

"Click on your project, and check that this file is not present in the
tab Build Phases. Normally no header files should stay here.
Clean and build it again, it should work!"

It does work.

On branch VendorBuildPhasesFix
Changes to be committed:
	modified:   Sparkle.xcodeproj/project.pbxproj

Building the Sparkle framework produced 10 Warnings caused by .h files
being added to the Build Rules Compile Sources. Thanks to tip from
Stackoverflow https://stackoverflow.com/questions/6509600/

"Click on your project, and check that this file is not present in the
tab Build Phases. Normally no header files should stay here.
Clean and build it again, it should work!"

It does work.
@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Jan 24, 2020

Thanks. If I'm reading the project file correctly, it removes .h files from the project completely, not just from build phases. Is that so?

@pteeson

This comment has been minimized.

Copy link
Contributor Author

pteeson commented Jan 25, 2020

@kornelski kornelski merged commit 9d8909c into sparkle-project:master Jan 25, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kornelski

This comment has been minimized.

Copy link
Member

kornelski commented Jan 25, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.