Use NSFileManager interface for DMG unarchive only for 10.7+. #183

Merged
merged 1 commit into from Jul 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

sinbad commented Jun 28, 2012

On 10.6, [NSFileManager copyItemAtPath:toPath:error:] can fail with "Argument list too long" if the app bundle contains too many files. The switch to NSFileManager was only required for 10.7 anyway, 10.6 always worked fine.

For background info, you might want to check this out: https://jira.atlassian.com/browse/SRCTREE-1066

Use NSFileManager interface for DMG unarchive only for 10.7+. On 10.6…
…, [NSFileManager copyItemAtPath:toPath:error:] can fail with "Argument list too long" if the app bundle contains too many files.

The switch to NSFileManager was only required for 10.7 anyway, 10.6 always worked fine.

andymatuschak added a commit that referenced this pull request Jul 6, 2012

Merge pull request #183 from sinbad/fix-10.6-arg-list-too-long
Use NSFileManager interface for DMG unarchive only for 10.7+.

@andymatuschak andymatuschak merged commit 118f3c5 into sparkle-project:master Jul 6, 2012

Contributor

andymatuschak commented Jul 6, 2012

Excellent; thank you. I'm sorry this caused so much trouble!

Contributor

sinbad commented Jul 6, 2012

A small price to pay for such an excellent library :) Thanks for accepting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment