pull-request to help plugin/bundle developers avoid class collisions #22

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@rudyrichter
Contributor

added defines to prefix all the class names with the contents of the ClassPrefix preprocessor macro so that plugin/bundle developers can avoid namespace collisions with the app and other plugin authors that make use of Sparkle.

@jakepetroules
Member

This could potentially be useful. @pornel, thoughts?

@pornel
Member
pornel commented Jun 29, 2014

It's a hack, so I'd rather not do this unless there's a clear need for it, and given that there hasn't been a ton of +1s on this issue since 2011, it may not be worth it.

Current Apple's recommendations are to use 3-letter name prefix (which won't collide with Sparkle's 2-letter prefix), and Swift will be immune to this problem.

@pornel pornel closed this Jun 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment