Enable deployment postprocessing in Release #2286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This properly strips binaries in Release builds that weren't being stripped before.
Note that for developers that were including Sparkle as a subproject and archiving their app with Xcode, this setting was already set for them (so this is already a configuration we have been supporting).
We deploy the dSYM files so this shouldn't be problematic. Even in a simple test case I made, I didn't see any lacking obj-c symbols in a crash I simulated.
Misc Checklist
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Tested using
make release
built Sparkle framework in a test app I have.macOS version tested: 13.0.1 (22A400)