New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent catastrophic data loss when finish_installation.app is not present for any reason #295

Merged
merged 0 commits into from Jun 28, 2014

Conversation

Projects
None yet
2 participants
@danielpunkass
Contributor

danielpunkass commented Sep 26, 2013

HI Andy - I ran across this when for reasons I won't go into, I ended up with a build of Sparkle.framework that had a missing finish_installation.app. As luck would have it the failure path for this scenario is to continue the effort to copy the finish_installation.app to the App Support folder, but to do so by attempting to write over the host's app support folder itself.

@kornelski kornelski merged commit 192c3b4 into sparkle-project:master Jun 28, 2014

@danielpunkass

This comment has been minimized.

Show comment
Hide comment
@danielpunkass

danielpunkass Sep 4, 2014

Contributor

Thanks for taking the fix!

Contributor

danielpunkass commented Sep 4, 2014

Thanks for taking the fix!

@danielpunkass danielpunkass deleted the danielpunkass:andymatuschak branch Sep 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment