Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --all flag to validate all templates #299

Merged
merged 6 commits into from Aug 4, 2019

Conversation

@luckymike
Copy link
Contributor

commented Jul 7, 2019

I'm not sure if this method of collecting all the template names is too naive. It seems like it should work.

closes #2

luckymike added some commits Jul 7, 2019

@luckymike

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

I took the easy route of validating each template and returning the results. It might be nicer to collect all the results and display a "valid/invalid" list.

@slyness

slyness approved these changes Jul 9, 2019

Copy link
Member

left a comment

code and syntax review looks good to me.

@luckymike

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

The failed CI run is an accidental branch push that I deleted.

@chrisroberts
Copy link
Member

left a comment

Awesome, this looks great. Thanks!

@chrisroberts chrisroberts merged commit 2fdf2bd into sparkleformation:develop Aug 4, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.