Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add grammar and nodes for css3 media queries #53
This has the same problem I had in #49 - definition of the and/or/not keywords prevented their use elsewhere, even in things like ".notification". Also, some files are missing in the manifest, preventing packaging.
I found a rex feature called "states", which essentially lets you define different contexts for the lexical words. So you can say that inside a media query list, and/or/not are keywords, while everywhere else they aren't.
I've created a branch off of this for the changes I've made - https://github.com/JasonBarnabe/csspool/tree/media . I don't know what the preferred way to apply that is (create a pull request against this one?).
Once this goes in I can update #49 as well with the same method.
Yeah I realized I omitted the new files in the manifest after i pushed, but was too lazy to update it
I had no idea about rex states, that makes sense. I think you should ask if you could maintain the CSS3 branch as your own repo. because the owners seem to be busy with other things, and you seem to be the most active with it. I would definitely contribute more if the code I wrote were pulled in or commented on.
Oh and good work
I've fixed up my master branch at https://github.com/JasonBarnabe/csspool. It's based off of the css3 branch and includes your changes here, as well as some other fixes I had waiting for merge. I intend to continue development there, while still sending pull requests here in case someone wakes up.
As I'm actively using csspool for my website, I'd be glad to merge in anything else you have to contribute.