New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grammar and nodes for css3 media queries #53

Merged
merged 1 commit into from Jun 29, 2014

Conversation

Projects
None yet
2 participants
@luke-gru
Contributor

luke-gru commented Jul 3, 2013

grammar based off http://www.w3.org/TR/css3-mediaqueries/#syntax

C3SSPool ;)

@JasonBarnabe

This comment has been minimized.

Show comment
Hide comment
@JasonBarnabe

JasonBarnabe Aug 19, 2013

Contributor

This has the same problem I had in #49 - definition of the and/or/not keywords prevented their use elsewhere, even in things like ".notification". Also, some files are missing in the manifest, preventing packaging.

I found a rex feature called "states", which essentially lets you define different contexts for the lexical words. So you can say that inside a media query list, and/or/not are keywords, while everywhere else they aren't.

I've created a branch off of this for the changes I've made - https://github.com/JasonBarnabe/csspool/tree/media . I don't know what the preferred way to apply that is (create a pull request against this one?).

Once this goes in I can update #49 as well with the same method.

Contributor

JasonBarnabe commented Aug 19, 2013

This has the same problem I had in #49 - definition of the and/or/not keywords prevented their use elsewhere, even in things like ".notification". Also, some files are missing in the manifest, preventing packaging.

I found a rex feature called "states", which essentially lets you define different contexts for the lexical words. So you can say that inside a media query list, and/or/not are keywords, while everywhere else they aren't.

I've created a branch off of this for the changes I've made - https://github.com/JasonBarnabe/csspool/tree/media . I don't know what the preferred way to apply that is (create a pull request against this one?).

Once this goes in I can update #49 as well with the same method.

@JasonBarnabe JasonBarnabe referenced this pull request Aug 19, 2013

Closed

Support @supports #49

@luke-gru

This comment has been minimized.

Show comment
Hide comment
@luke-gru

luke-gru Aug 19, 2013

Contributor

Hey Jason,

Yeah I realized I omitted the new files in the manifest after i pushed, but was too lazy to update it 😸 That and no one was commenting on it, lol

I had no idea about rex states, that makes sense. I think you should ask if you could maintain the CSS3 branch as your own repo. because the owners seem to be busy with other things, and you seem to be the most active with it. I would definitely contribute more if the code I wrote were pulled in or commented on.

Oh and good work 😉

Contributor

luke-gru commented Aug 19, 2013

Hey Jason,

Yeah I realized I omitted the new files in the manifest after i pushed, but was too lazy to update it 😸 That and no one was commenting on it, lol

I had no idea about rex states, that makes sense. I think you should ask if you could maintain the CSS3 branch as your own repo. because the owners seem to be busy with other things, and you seem to be the most active with it. I would definitely contribute more if the code I wrote were pulled in or commented on.

Oh and good work 😉

@JasonBarnabe

This comment has been minimized.

Show comment
Hide comment
@JasonBarnabe

JasonBarnabe Aug 25, 2013

Contributor

I've fixed up my master branch at https://github.com/JasonBarnabe/csspool. It's based off of the css3 branch and includes your changes here, as well as some other fixes I had waiting for merge. I intend to continue development there, while still sending pull requests here in case someone wakes up.

As I'm actively using csspool for my website, I'd be glad to merge in anything else you have to contribute.

Contributor

JasonBarnabe commented Aug 25, 2013

I've fixed up my master branch at https://github.com/JasonBarnabe/csspool. It's based off of the css3 branch and includes your changes here, as well as some other fixes I had waiting for merge. I intend to continue development there, while still sending pull requests here in case someone wakes up.

As I'm actively using csspool for my website, I'd be glad to merge in anything else you have to contribute.

@JasonBarnabe JasonBarnabe merged commit 2c123d3 into sparklemotion:css3 Jun 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment