Skip to content

FileSaver cannot save as "path?query" on Windows #163

Closed
kitamomonga opened this Issue Nov 6, 2011 · 3 comments

2 participants

@kitamomonga

Windows filesystem does not allow to use character "?" for filenames.
"path?query" would be "path@query" or something (like wget for Windows).

As a matter of fact, mechanize should escape/replace more and more characters for saving files to disk (see: wget and cURL and Content-Disposition Security Advisory), but I think it is just another (big) issue.

@drbrain
Sparkle Motion member
drbrain commented Nov 7, 2011

Found this advisory for curl: http://curl.haxx.se/docs/adv_20101013.html

@drbrain drbrain was assigned Nov 7, 2011
@drbrain drbrain added a commit that referenced this issue Nov 9, 2011
@drbrain drbrain Add mention of fix of Issue #163 f4ef00e
@drbrain
Sparkle Motion member
drbrain commented Nov 9, 2011

Other than writing a non-existent special dot-file when mechanize is used in the home directory I think I can close this issue. Mechanize already avoids overwriting existing files when saving files (so you can't overwrite .login, etc.)

@drbrain drbrain closed this Nov 9, 2011
@kitamomonga

ContentDispositionParser!! awesome!
I am anxiously awaiting pre-release/2.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.