Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain webpages cause the formation of invalid queries #536

Closed
weshatheleopard opened this issue Dec 19, 2018 · 0 comments
Closed

Certain webpages cause the formation of invalid queries #536

weshatheleopard opened this issue Dec 19, 2018 · 0 comments

Comments

@weshatheleopard
Copy link
Contributor

@weshatheleopard weshatheleopard commented Dec 19, 2018

I've encountered a webpage that contains a form with the following field:

<input id="searchText" name="" type="text" />

It turns out that build_query method actually builds the query &= out of that field, whereas browsers actually do NOT submit anything for that particular field. Web servers seem to silently ignore such invalid field, but our test framework craps out.

Solution: fields that have blank name should be ignored altogether.

leejarvis added a commit that referenced this issue Feb 11, 2019
We shouldn't try to submit empty strings to the server, since browsers
also simply ignore these fields

Fixes #536
leejarvis added a commit that referenced this issue Feb 12, 2019
We shouldn't try to submit empty strings to the server, since browsers
also simply ignore these fields

Fixes #536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant