Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webrick to development dependecies #557

Merged
merged 3 commits into from Jan 23, 2021
Merged

Conversation

@pvalena
Copy link
Contributor

@pvalena pvalena commented Jan 6, 2021

as it's used in the tests.

as it's used in the tests.
@flavorjones flavorjones force-pushed the pvalena:patch-1 branch from e097bf8 to d4c28e1 Jan 23, 2021
@flavorjones
Copy link
Member

@flavorjones flavorjones commented Jan 23, 2021

I've rebased off master to run the test suite.

@flavorjones
Copy link
Member

@flavorjones flavorjones commented Jan 23, 2021

I've added a commit converting this dependency to a "runtime" type, since WEBrick is used outside the test suite.

[skip ci]
@flavorjones
Copy link
Member

@flavorjones flavorjones commented Jan 23, 2021

All the CRuby versions are green. JRuby is still failing, for reasons unrelated to this PR. Merging. Thank you!

@flavorjones flavorjones merged commit 25157bd into sparklemotion:master Jan 23, 2021
6 of 7 checks passed
6 of 7 checks passed
@github-actions
test (2.3)
Details
@github-actions
test (2.4)
Details
@github-actions
test (2.5)
Details
@github-actions
test (2.6)
Details
@github-actions
test (2.7)
Details
@github-actions
test (3.0)
Details
@github-actions
test (jruby) test (jruby)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants