New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line column to message #1304

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@spk
Contributor

spk commented Jun 18, 2015

Useful for map(&:to_s) and simple output

@spk spk force-pushed the spk:add-line-column-to-syntax-error branch from 43d4955 to c12c488 Nov 15, 2015

@flavorjones

This comment has been minimized.

Member

flavorjones commented Feb 17, 2016

Oooh, I really like this feature. I may clean it up so that it reads better, but thanks for putting the time and though into this!

@flavorjones flavorjones added this to the 1.6.8 milestone Feb 17, 2016

@spk spk force-pushed the spk:add-line-column-to-syntax-error branch from baa88fa to 49cc162 Mar 5, 2016

@spk

This comment has been minimized.

Contributor

spk commented Mar 5, 2016

Hi @flavorjones, thanks, don't hesitate to comment I will take the time to fix the issues you will report.

@spk spk force-pushed the spk:add-line-column-to-syntax-error branch from 49cc162 to 10c8149 Mar 8, 2016

@flavorjones flavorjones modified the milestones: 1.7.0, 1.6.8 May 30, 2016

spk added some commits Jun 18, 2015

Add line column to message
Useful for `map(&:to_s)` and simple output

@spk spk force-pushed the spk:add-line-column-to-syntax-error branch from 10c8149 to cbdd787 Jul 26, 2016

@flavorjones

This comment has been minimized.

Member

flavorjones commented Jan 14, 2017

Looks like this works on rbx-3 without needing to make the change in cbdd787.

@flavorjones

This comment has been minimized.

Member

flavorjones commented Jan 15, 2017

Merged the initial commit of this PR manually.

Thank you for the PR!

@flavorjones flavorjones modified the milestones: 1.7.1, 2.0.0 Jan 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment