Fix for #843 #1327
Closed
Fix for #843 #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace information tied to the attribute nodes
…this change fixes the segfault
This fixes Nokogiri::XML::Attr#namespace not working when used with XmlReader, because namespaces never get cached in that scenario. We can't add it to the cache at this point, because the node that defined the namespace is not available.
|
Hm I'm not familiar with appveyor, but that failure |
|
@codekitchen Don't worry about appveyor, it is currently broken. PR #1310 fixes that, among others issues. |
|
good to know, thanks @larskanis |
codekitchen
added a commit
to instructure/canvas-lms
that referenced
this pull request
Aug 10, 2015
This is required for ratom until this PR is merged sparklemotion/nokogiri#1327 refs CNVS-22298 Change-Id: If99e10659b5b17e8cc8e0df49fbf5ba1214b8612 Reviewed-on: https://gerrit.instructure.com/59948 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Product-Review: Brian Palmer <brianp@instructure.com>
codekitchen
added a commit
to instructure/canvas-lms
that referenced
this pull request
Aug 10, 2015
This is required for ratom until this PR is merged sparklemotion/nokogiri#1327 refs CNVS-22298 Change-Id: If99e10659b5b17e8cc8e0df49fbf5ba1214b8612 Reviewed-on: https://gerrit.instructure.com/59948 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Product-Review: Brian Palmer <brianp@instructure.com>
codekitchen
added a commit
to instructure/canvas-lms
that referenced
this pull request
Aug 18, 2015
This is required for ratom until this PR is merged sparklemotion/nokogiri#1327 refs CNVS-22298 Change-Id: If99e10659b5b17e8cc8e0df49fbf5ba1214b8612 Reviewed-on: https://gerrit.instructure.com/59948 Reviewed-by: Cody Cutrer <cody@instructure.com> Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Product-Review: Brian Palmer <brianp@instructure.com>
|
Tentatively targetting 1.6.8 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took #1058 and fixed the Java implementation so that the tests pass.
Without these fixes, the test crashes on MRI (failed assert) and fails in JRuby.