Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to the ruby/setup-ruby action #2162

Merged
merged 1 commit into from
Jan 4, 2021
Merged

ci: switch to the ruby/setup-ruby action #2162

merged 1 commit into from
Jan 4, 2021

Conversation

parndt
Copy link
Contributor

@parndt parndt commented Jan 4, 2021

What problem is this PR intended to solve?

This switches the setup-ruby action to the one created by the
ruby organisation which has more
advanced features than the one already in use.

Most notably, this handles installing Bundler, bundling, and caching the
resulting bundle.

Have you included adequate test coverage?

Yes, which is to say it hasn't changed any code or tests, just how they
are run.

Does this change affect the behavior of either the C or the Java implementations?

No, just how CI runs, and you can see the results on this PR 馃槃.

@flavorjones
Copy link
Member

@parndt Sweet! Thanks very much for showing us how to do this. Merging!

@flavorjones flavorjones merged commit 4b55ecb into sparklemotion:master Jan 4, 2021
@parndt parndt deleted the use-ruby-setup-ruby branch January 4, 2021 02:32
@parndt
Copy link
Contributor Author

parndt commented Jan 4, 2021

@flavorjones you're very welcome; thanks for all the work on Nokogiri! Happy to have helped. 馃帀

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants