Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up tests #2215

Merged
merged 3 commits into from Apr 6, 2021
Merged

clean up tests #2215

merged 3 commits into from Apr 6, 2021

Conversation

@flavorjones
Copy link
Member

@flavorjones flavorjones commented Apr 6, 2021

What problem is this PR intended to solve?

Just cleaning up some tests, making some of the GC-specific tests more declarative and introducing a standard way to skip platform-specific tests.

@codeclimate
Copy link

@codeclimate codeclimate bot commented Apr 6, 2021

Code Climate has analyzed commit 72d96fe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.0% change).

View more on Code Climate.

flavorjones added 2 commits Apr 6, 2021
@flavorjones flavorjones force-pushed the flavorjones-valgrind-test-helpers branch from 8f6c714 to d33b021 Apr 6, 2021
because forking is slow and this cuts a few seconds off the test suite
@flavorjones flavorjones merged commit 5562eb7 into main Apr 6, 2021
19 checks passed
19 checks passed
@github-actions
cruby-test-system-libraries (2.7)
Details
@github-actions
cruby-test-system-libraries (3.0)
Details
@github-actions
cruby-test-vendored-libraries (2.7)
Details
@github-actions
cruby-test-vendored-libraries (3.0)
Details
@nokobot
ci.nokogiri.org/cruby-2.5 Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-2.6 Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-2.7 Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-3.0 Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-gem-test Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-native-gem-test Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-native-gem-test-32bit Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-on-musl Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-on-vanilla-ubuntu Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/cruby-with-libxmlruby Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/jruby-9.2 Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/jruby-gem-test Nokobot is happy with this job.
Details
@nokobot
ci.nokogiri.org/rubocop Nokobot is happy with this job.
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@flavorjones flavorjones deleted the flavorjones-valgrind-test-helpers branch Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant