Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v1.11.x) update tests to work with system libxml 2.9.12, and work around windows dll unloading issue #2243

Conversation

@flavorjones
Copy link
Member

@flavorjones flavorjones commented May 19, 2021

What problem is this PR intended to solve?

#2241. This is applying #2240 to the v1.11.x branch for a patch release.

Have you included adequate test coverage?

Existing test coverage is adequate on Appveyor, however in this PR we also add Github Actions coverage which is a bit faster than Appveyor for faster feedback loops.

Does this change affect the behavior of either the C or the Java implementations?

It changes the behavior of libxml2's memory management, but only on Windows when using system DLLs.

@flavorjones flavorjones merged commit 42354e4 into v1.11.x May 19, 2021
21 of 27 checks passed
@flavorjones flavorjones deleted the flavorjones-v1_11_x-update-tests-to-work-with-system-libxml-2_9_12 branch May 19, 2021
@flavorjones flavorjones added this to the v1.11.x patch releases milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant