/ nokogiri Public
(v1.11.x) update tests to work with system libxml 2.9.12, and work around windows dll unloading issue #2243
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What problem is this PR intended to solve?
#2241. This is applying #2240 to the v1.11.x branch for a patch release.
Have you included adequate test coverage?
Existing test coverage is adequate on Appveyor, however in this PR we also add Github Actions coverage which is a bit faster than Appveyor for faster feedback loops.
Does this change affect the behavior of either the C or the Java implementations?
It changes the behavior of libxml2's memory management, but only on Windows when using system DLLs.