Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTML4::Document.to_xhtml self-closing tags (v1.12.x) #2327

merged 1 commit into from Sep 24, 2021


Copy link

This is #2326 backported to v1.12.x for a patch release.

Commit 1d06b4f introduced NO_EMPTY_TAGS into
SaveOptions::DEFAULT_XHTML which libxml2 ignored due to a
long-standing bug in serialization.

libxml2 v2.9.11 fixed that serialization bug
( and started
paying attention to the NO_EMPTY_TAGS save option, resulting in seeing
output containing, e.g. `<col></col>` instead of `<col/>`.

This commit updates the default XHTML save options to drop the
NO_EMPTY_TAGS flag, restoring this behavior.

Closes #2324
@flavorjones flavorjones added this to the v1.12.x patch releases milestone Sep 23, 2021
@flavorjones flavorjones merged commit 01e1618 into v1.12.x Sep 24, 2021
59 checks passed
@flavorjones flavorjones deleted the 2324-xhtml-self-closing-tags_v1.12.x branch September 24, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant