fix JRuby SAX parser entity handling (v1.12.x backport) #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- xml/sax/test_parser.rb - xml/sax/test_push_parser.rb
NokogiriErrorHandler stores RubyException but also accepts (and type-converts) Exception and RaiseException. NokgiriHandler uses NokogiriErrorHandler under the hood. NokogiriErrorHandler classes use addError consistently everywhere.
to avoid XXE injections. This behavior now matches the CRuby implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What problem is this PR intended to solve?
GHSA-2rr5-8q37-2w7h (may be private for now)
This is a backport of #2328 for a v1.12.x patch release.
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
The Java implementation behavior now matches the C implementation behavior.