Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML parse processing instructions (backport to v1.13.x) #2509



Copy link

What problem is this PR intended to solve?

Add test coverage for HTML parsing of processing instructions, and update the packaged nekohtml library used for the JRuby implementation.

(backport to v1.13.x)

Have you included adequate test coverage?

Yes, additional coverage provided.

Does this change affect the behavior of either the C or the Java implementations?

The Java implementation is still different from the C implementation for HTML4, but test coverage describes those differences.

@flavorjones flavorjones added the backport Backport of a PR to the current release branch label Apr 10, 2022
@flavorjones flavorjones added this to the v1.13.x patch releases milestone Apr 10, 2022
@flavorjones flavorjones changed the base branch from main to v1.13.x April 10, 2022 15:57
@flavorjones flavorjones reopened this Apr 10, 2022
@flavorjones flavorjones force-pushed the flavorjones-parse-processing-instructions-v1.13.x branch 3 times, most recently from 825b08f to 4905a4d Compare April 10, 2022 17:50
so let's pick an unambiguously-inline element to test.
Added test coverage to describe behavior of our parsers, and update
nekohtml to 1.9.22.noko2.
@flavorjones flavorjones force-pushed the flavorjones-parse-processing-instructions-v1.13.x branch from 4905a4d to 0feac5a Compare April 10, 2022 18:08
@flavorjones flavorjones merged commit b848031 into v1.13.x Apr 10, 2022
47 of 48 checks passed
@flavorjones flavorjones deleted the flavorjones-parse-processing-instructions-v1.13.x branch April 10, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
backport Backport of a PR to the current release branch
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant