Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve encoding reader performance (backport to v1.13.x) #2510

Merged
merged 2 commits into from Apr 11, 2022

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Apr 10, 2022

What problem is this PR intended to solve?

HTML4 document encoding detection improvements.

Have you included adequate test coverage?

Yes, there is a quick-and-dirty test for the v1.13.x branch, see #2448 for a more complete perf testing approach that's on main.

Does this change affect the behavior of either the C or the Java implementations?

No.

@flavorjones flavorjones added topic/performance backport labels Apr 10, 2022
@flavorjones flavorjones added this to the v1.13.x patch releases milestone Apr 10, 2022
@flavorjones flavorjones changed the base branch from main to v1.13.x Apr 10, 2022
@flavorjones flavorjones force-pushed the flavorjones-encoding-reader-performance-v1.13.x branch from 9bc9651 to e444525 Compare Apr 10, 2022
@flavorjones flavorjones merged commit 6a20ee4 into v1.13.x Apr 11, 2022
94 of 96 checks passed
@flavorjones flavorjones deleted the flavorjones-encoding-reader-performance-v1.13.x branch Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport topic/performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant