Merged
Conversation
flavorjones
force-pushed
the
2677-jruby-namespaced-attributes
branch
from
b800369 to
b4819c5
Compare
mohanned6524
approved these changes
Oct 21, 2022
flavorjones
force-pushed
the
2677-jruby-namespaced-attributes
branch
from
b4819c5 to
be4aebf
Compare
including a failing test for JRuby round-trip of an attribute
flavorjones
force-pushed
the
2677-jruby-namespaced-attributes
branch
from
be4aebf to
db8d3f1
Compare
flavorjones
changed the title
Previously, it was matching against the full name. Also, make sure that we create new attributes with setAttributeNS (even if the URI is null) so that we can retrieve with `localName`. Note that we need additional logic to handle unknown namespaces.
flavorjones
force-pushed
the
2677-jruby-namespaced-attributes
branch
from
db8d3f1 to
c142785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#2677 pointed out inconsistent behavior in the JRuby implementation with respect to namespaced attributes.
This may be an incomplete fix, but it's good enough to ship.
Closes #2677
Have you included adequate test coverage?
Yes
Does this change affect the behavior of either the C or the Java implementations?
This PR fixes the JRuby behavior to match the CRuby behavior.