Support parsing noscript content in script-enabled mode#3231
Support parsing noscript content in script-enabled mode#3231flavorjones merged 8 commits intosparklemotion:mainfrom
Conversation
This change adds support for parsing noscript content with the scripting flag enabled. In this case, Gumbo will treat the content of the noscript element as raw text, exactly as the browser would.
|
Suggestions on a better option name are especially welcome. I didn't want to use something like |
|
I just realized that I haven't had the html5lib tests running so this is really not ready for review yet. Gotta figure out what I did wrong here first. |
|
It seems that we're now passing the scripting enabled html5lib tree construction tests. |
|
This PR should also update the docstring in Let me know if you'd like me to put in any of this work? I'm happy to do as much or as little as you like. ♥ |
The name Or if we want to be funny, |
I did that as well. But I left the existing option name. I'll defer to your experience in API design. |
and update the CHANGELOG
46c2001 to
e3f326a
Compare
|
The changelog entry isn't worded perfectly ... I'll fix it in postproduction |
This change adds support for parsing noscript content with the scripting flag enabled. In this case, Gumbo will treat the content of the noscript element as raw text, exactly as the browser would.
What problem is this PR intended to solve?
Closes #3178
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
It adds support for this parsing option to libgumbo only.