Implement XML::Reader.new with keyword args and forward Reader() to it#3326
Merged
Conversation
Contributor
Author
|
Reader.from_io and Reader.from_memory are C functions, @flavorjones ! |
Member
|
Thanks for your patience. The last couple of weeks have been really busy, but I'm hoping to review and merge this in the next week or so! |
flavorjones
force-pushed
the
Update_XML_Reader
branch
2 times, most recently
from
d6cb07d to
14432b9
Compare
Member
|
Rebased. Kept the tests but dropped the |
flavorjones
changed the title
XML::Reader() now forwards to this method. Expanded documentation for it.
flavorjones
force-pushed
the
Update_XML_Reader
branch
from
14432b9 to
5efcc6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Adds support for keyword args for optional args for Nokogiri::XML::Reader#initialize
Have you included adequate test coverage?
Yas, says @flavorjones
Does this change affect the behavior of either the C or the Java implementations?