Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Run valgrind on Travis CI #813

Open
wants to merge 1 commit into from

3 participants

@benlangfeld

Relevant discussion in #799. Seems Travis is broken on my fork, so submitting this to trigger an official build.

@leejarvis
Owner

Ben, did you manage to get this working?

@benlangfeld

@leejarvis Looks good-ish now. Some failures due to slow XPath, but I can't do much about that here.

@leejarvis
Owner

Thanks, looks good. However I'm not sure this is worth it if we're going to constantly get these kind of failures. I think if something needs debugging we can run valgrind on local machines to avoid the long waits and failures. I'm open to suggestions, though.

@benlangfeld

The failures are in the rspec test suite.

@leejarvis
Owner

Right! I misread the output, I'll check this out tomorrow. Cheers!

@flavorjones flavorjones self-assigned this
@flavorjones
Owner

@benlangfeld and @leejarvis -- I'd love to get valgrind running on Travis, except that the only assertion I'm currently making on the valgrind run is with my eyeballs.

So an interesting prerequisite is to wire up an assertion of some sort into https://github.com/jbarnette/hoe-debugging, so that the build fails if unexpected output is emitted. Difficulty level: medium.

Also, it would be great if we could with- and without-valgrind as separate builds. I know we can do this, because I'm looking at jruby's travis config and jruby's build and they're clearly doing something amazing with the matrix bit that I can't quite grok because I don't fully understand the fully operational battle station that is TravisCI in 2015. Difficulty level: medium for nitwits like me, probably low for both of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 23, 2014
  1. @benlangfeld
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 0 deletions.
  1. +6 −0 .travis.yml
  2. +2 −0  Rakefile
View
6 .travis.yml
@@ -25,3 +25,9 @@ matrix:
jdk: openjdk7
- rvm: rbx-19mode
jdk: openjdk7
+
+before_install:
+ - sudo apt-get update
+ - sudo apt-get install valgrind
+
+script: rake ci
View
2  Rakefile
@@ -243,4 +243,6 @@ task "gem:windows" => "gem" do
sh("env PKG_CONFIG_PATH=#{pkg_config_path} RUBY_CC_VERSION=#{ruby_cc_version} rake cross native gem") || raise("build failed!")
end
+task :ci => [:default, 'test:valgrind']
+
# vim: syntax=Ruby
Something went wrong with that request. Please try again.