Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement efficient weighted random sampling with and without replacement for Spark DataFrame #2606

Merged
merged 11 commits into from Jul 20, 2020
Merged

Conversation

yitao-li
Copy link
Contributor

@yitao-li yitao-li commented Jul 17, 2020

No description provided.

yitao-li added 4 commits Jul 17, 2020
Signed-off-by: yl790 <yitao@rstudio.com>
Signed-off-by: yl790 <yitao@rstudio.com>
Signed-off-by: yl790 <yitao@rstudio.com>
Signed-off-by: yl790 <yitao@rstudio.com>
@yitao-li yitao-li requested a review from javierluraschi Jul 17, 2020
@falaki
Copy link
Collaborator

@falaki falaki commented Jul 17, 2020

Databricks Connect tests failed. View logs here.

Signed-off-by: yl790 <yitao@rstudio.com>
@falaki
Copy link
Collaborator

@falaki falaki commented Jul 17, 2020

Databricks Connect tests succeeded. View logs here.

Signed-off-by: yl790 <yitao@rstudio.com>
Copy link
Collaborator

@javierluraschi javierluraschi left a comment

This functionality is a great addition, nicely done!

yitao-li added 2 commits Jul 17, 2020
Signed-off-by: yl790 <yitao@rstudio.com>
Signed-off-by: yl790 <yitao@rstudio.com>
@falaki
Copy link
Collaborator

@falaki falaki commented Jul 17, 2020

Databricks Connect tests failed. View logs here.

@falaki
Copy link
Collaborator

@falaki falaki commented Jul 17, 2020

Databricks Connect tests failed. View logs here.

@falaki
Copy link
Collaborator

@falaki falaki commented Jul 17, 2020

Databricks Connect tests failed. View logs here.

yitao-li added 3 commits Jul 20, 2020
Signed-off-by: yl790 <yitao@rstudio.com>
Signed-off-by: yl790 <yitao@rstudio.com>
Signed-off-by: yl790 <yitao@rstudio.com>
@falaki
Copy link
Collaborator

@falaki falaki commented Jul 20, 2020

Databricks Connect tests succeeded. View logs here.

@yitao-li yitao-li merged commit 15e165c into sparklyr:master Jul 20, 2020
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants