join methods for tbl_spark #2651
Conversation
Signed-off-by: wkdavis <william.davis@worthingtonindustries.com>
| NULL | ||
|
|
||
| #' @rdname join.tbl_spark | ||
| #' @export |
There was a problem hiding this comment.
Minor: currently the entry for this method is export(inner_join.tbl_spark) in the NAMESPACE file, which is a bit off from the truth.
I think if you make the suggested change below and re-run roxygen2::roxygenize(), the NAMESPACE entry will become S3method(inner_join,tbl_spark), which is more technically correct.
| #' @export | |
| #' @importFrom dplyr inner_join | |
| #' @export |
And same applies for all other S3 methods in this file.
There was a problem hiding this comment.
Agreed, should be an s3 method. I made the changes - it required reexporting the generics from dplyr in order to register the s3 method (I tried using just the importFrom block as you suggested but that did not register the methods).
Looks good overall! Thanks for working on this
My only suggested change is about generating actual S3 method entries in the NAMESPACE file. Let me know what you think.
Signed-off-by: wkdavis <william.davis@worthingtonindustries.com>
|
Databricks Connect tests succeeded. View logs here. |
|
Databricks Connect tests succeeded. View logs here. |
@yl790 It looks like the default test version of Spark is 2.3.0, but I can only run >= 3.0.0 on my machine due to my version of Java, so I will watch the builds to make sure it passes.