New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasn't testing all the methods #26

Merged
merged 2 commits into from Sep 9, 2017

Conversation

Projects
None yet
2 participants
@yanick
Contributor

yanick commented Aug 23, 2017

the original check

while ( my ($pkg, $methods) = each %methods ) { 	
can_ok( $pkg, @$methods ); 
} 

was checking only the first method (the second method was being considered as the test description, and the rest just tossed out by can_ok).

Since I was in the file, I also gathered the second segment into a single subtest.

yanick added some commits Aug 23, 2017

wasn't testing all the methods
the original check

```
while ( my ($pkg, $methods) = each %methods ) {
	can_ok( $pkg, @$methods );
}
```

was checking only the first method (the second method was being
considered as the test description, and the rest just tossed out  by `can_ok`).

@creaktive creaktive merged commit e146b29 into sparky:master Sep 9, 2017

@creaktive

This comment has been minimized.

Show comment
Hide comment
@creaktive

creaktive Sep 9, 2017

Collaborator

Thanks, merged!

Collaborator

creaktive commented Sep 9, 2017

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment