From 23d371621edb2070d2a46fb657135c7323e78ce2 Mon Sep 17 00:00:00 2001 From: Sparsh Sam <110058692+sparshsam@users.noreply.github.com> Date: Sun, 2 Aug 2026 21:32:52 -0400 Subject: [PATCH] ci: build MSIX on test builds too so the packaging path is validated - Remove the dev/test skip in build-windows.yml's MSIX step: every branch/PR build now builds OpenReader-test.msix (attached to the workflow artifact, never published), so a broken MSIX packaging path surfaces in CI instead of only at release time. Missing MakeAppx.exe remains the only valid skip. Co-Authored-By: Claude --- .github/workflows/build-windows.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 079c409..dafeb98 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -119,12 +119,10 @@ jobs: run: | $ErrorActionPreference = "Stop" - # Only build MSIX for real release versions, not dev/test builds - $buildVersion = "$env:VERSION" - if ($buildVersion -eq "0.0.0-dev" -or $buildVersion -like "*-test") { - Write-Host "Skipping MSIX build for dev/test version: $buildVersion" - exit 0 - } + # Build the MSIX on every run (dev/test too) so the full packaging + # path is validated by CI without publishing a release. Test builds + # produce OpenReader-test.msix, attached to the workflow artifact. + # A missing MakeAppx.exe is the only reason to skip. # Locate MakeAppx.exe from Windows SDK $makeAppx = Get-Command "MakeAppx.exe" -ErrorAction SilentlyContinue