New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad indexing when some species have no Tvib #15

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@sjplimp
Copy link
Contributor

sjplimp commented Oct 23, 2018

Purpose

Fixed bug in compute tvib/grid with indexing into tally data structure. Was giving invalid
temperatures with mutli-species groups when some species had no vibrational DOF.

Author(s)

Steve

Backward Compatibility

Will change answers for per-grid-cell Tvib values.

Implementation Notes

Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in SPARTA are affected

Post Submission Checklist

Please check the fields below as they are completed

  • The feature or features in this pull request is complete
  • Suitable new documentation files and/or updates to the existing docs are included
  • One or more example input decks are included
  • The source code follows the SPARTA formatting guidelines

Further Information, Files, and Links

Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)

@stanmoore1 stanmoore1 self-assigned this Oct 23, 2018

@stanmoore1 stanmoore1 self-requested a review Oct 23, 2018

@stanmoore1 stanmoore1 merged commit 1501800 into master Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment