Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopNav & SideNav changes | Logo + menu trigger #762

Closed
SamusElderg opened this issue Apr 22, 2022 · 2 comments
Closed

TopNav & SideNav changes | Logo + menu trigger #762

SamusElderg opened this issue Apr 22, 2022 · 2 comments
Assignees

Comments

@SamusElderg
Copy link
Collaborator

SamusElderg commented Apr 22, 2022

Now that we have moved elements from the topNav and have room on all screen sizes (potentially) for the full horizontal logo, lets make the next few changes. This will also solve the sometimes-bad-UX aspect of locking the sidebar on medium desktop screens (you will be able to click the lock button even when you hover over the sidenav)

Currently:
image

Proposed (Rough obviously):
image

image

  • On hover of hamburger icon when sidebar is not locked, show a locked padlock
  • On hover of menu (not hover directly on hamburger icon) show unlocked padlock
  • Not hovering over either && sidebar not already locked: show no padlock
  • Not hovering over either && sidebar already locked && screen not large enough to always be locked: show locked padlock
@SamusElderg
Copy link
Collaborator Author

partial with 9b3ecd1
still need to consider adding the 'lock' icon in some cases

@SamusElderg
Copy link
Collaborator Author

I think we can close this now its basically already done indirectly except the lock icon stuff but i just created a branch and did the work and think the UI/UX is no better or worse, will just leave it as is for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant